Skip to content

fix: make getters convert uuid to string when calling toObject() and toJSON() #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: make getters convert uuid to string when calling toObject() and toJSON() #14890

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
762d063
fix: make getters convert uuid to string when calling toObject() and …
vkarpov15 Sep 16, 2024
5b5f3d8
style: fix lint
vkarpov15 Sep 16, 2024
499582a
Update lib/schema/uuid.js
vkarpov15 Sep 17, 2024
02162ff
Update lib/schema/uuid.js
vkarpov15 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/schema/uuid.js 
Co-authored-by: hasezoey <[email protected]>
  • Loading branch information
@vkarpov15 @hasezoey
vkarpov15 and hasezoey authored Sep 17, 2024
commit 02162ff62d13a23a2785532cabb5c3fbac2abb26
2 changes: 1 addition & 1 deletion lib/schema/uuid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function binaryToString(uuidBin) {
// i(hasezoey) dont quite know why, but "uuidBin" may sometimes also be the already processed string
let hex;
if (typeof uuidBin !== 'string' && uuidBin != null) {
hex = uuidBin != null && uuidBin.toString('hex');
hex = uuidBin.toString('hex');
const uuidStr = hex.substring(0, 8) + '-' + hex.substring(8, 8 + 4) + '-' + hex.substring(12, 12 + 4) + '-' + hex.substring(16, 16 + 4) + '-' + hex.substring(20, 20 + 12);
return uuidStr;
}
Expand Down