This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Block themes - update templateParts json #3511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldudzic
approved these changes
Mar 25, 2021
Contributor
danieldudzic
left a comment
danieldudzic
left a comment
There was a problem hiding this comment.
Tested this for both Mayland Blocks and Seedlet Blocks and it works fine 👍
pbking
force-pushed
the
update/block-themes-json-for-template-parts
branch
from
7cbe429 to
2600326
Compare
pbking
force-pushed
the
update/block-themes-json-for-template-parts
branch
from
2600326 to
f8f5d39
Compare
Contributor
|
c-D59303 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
json schema for template parts and their area terms was recently updated in WordPress/gutenberg#29828. Here, we update this for seedlet-blocks as well as add this json for mayland-blocks. This allows template parts defined by the theme to render under their corresponding block variations by default.
For example, when inspecting the header for mayland-blocks, we can see the block has the expected 'header' variation by presence of the block variations icon throughout the interface:
Related issue(s):