Themes: Translate custom templates in theme.json #29828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Feature] Templates API
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/custom-templates-i18n
branch
from
cacf117 to
b416996
Compare
gziolo
requested review from
TimothyBJacobs,
ajitbohra,
chrisvanpatten and
spacedmonkey
as code owners
gziolo
commented
Mar 15, 2021
This was referenced Mar 17, 2021
Member
|
According to #28410 (comment) it looks like |
Member
Author
They aren't translatable today. We can't tell what the future brings but it's better to keep them structured the same way as |
oandregal
approved these changes
Mar 17, 2021
Member
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
I see there's some conflicts with the theme-json docs. Other than that this is ready.
Special thanks for taking the time to add a new test for this! This should increase our confidence levels by an order of magnitude.
Member
|
Oh, just remembered one thing: when there're changes to the theme.json format I usually create the corresponding PR in theme-experiments (or let the themers know what changes are upcoming). |
Member
Author
Thanks for the reminder. I thought about that when I was testing changes with |
aristath
added a commit
to ProgressPlanner/Q
that referenced
this pull request
Mar 18, 2021
gziolo
force-pushed
the
update/custom-templates-i18n
branch
from
b416996 to
255e734
Compare
Member
Author
|
I opened PR for TT1-blocks theme: WordPress/theme-experiments#232 |
carolinan
reviewed
Mar 19, 2021
Contributor
carolinan
left a comment
carolinan
left a comment
There was a problem hiding this comment.
With this PR I can't get the "postTypes": [ "page", "post" ] setting to work. The template is only available for pages.
Member
Author
It's my last refactoring where I made it explicit what is sourced from the config file and I forgot to list |
gziolo
force-pushed
the
update/custom-templates-i18n
branch
from
255e734 to
1c20e0e
Compare
Member
Author
@carolinan, it should be fixed now. |
swissspidy
reviewed
Mar 19, 2021
gziolo
force-pushed
the
update/custom-templates-i18n
branch
from
65efc6b to
0d410ee
Compare
aristath
approved these changes
Mar 19, 2021
7 tasks
2 tasks
Member
|
This PR somehow caused an issue with missing items in theme.json files 🤔 |
Member
Author
|
I think I might introduce a regression there around presets. I will improve our test coverage first and see how to fix it. |
2 tasks
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative to #28783. The difference is that rather than changing the way translatable fields are marked in
experimental-18n-theme.json, the structure ofexperimental-theme.jsonforcustomTemplatesandtemplatePartsgets updated to fit the i18n extracting logic. It also aligns with how settings are declared like color palettes for font sizes.Before
{ "templateParts": { "header": { "area": "header" }, "footer": { "area": "footer" } } }After
{ "templateParts": [ { "name": "header", "area": "header" }, { "name": "footer", "area": "footer" } ] }#27778 introduced a new field in the
theme.jsonfile, thecustomTemplatesto declare custom page templates to be shown to the user in places like:#28700 integrated the processing of that field into the
WP_Theme_JSON/WP_Theme_JSON_Resolverclasses. This is the next step of that integration: make it translatable.Changes:
experimental-i18n-theme.json, so wp-cli can understand what needs to be translated.WP_Theme_JSON_Resolverto retrieve the translated version of this field.How has this been tested?
tt1-blockstheme.experimental-theme.jsonfile to contain:In addition to that, a new unit test was added to cover translation logic applied to
theme.json.Screenshots
Types of changes
New feature (non-breaking change which adds functionality).
Checklist: