Seedlet blocks: fix broken footer #4360
Conversation
jffng
left a comment
jffng
left a comment
There was a problem hiding this comment.
This fixes the issue in my testing, thanks! I have one comment but I am not sure it's worth holding up the fix because it may require a deeper rethinking of alignments.
| font-family: var(--wp--preset--font-family--headings); | ||
| white-space: pre-wrap; | ||
| &[class*="wp-container-"] { | ||
| margin-left: auto !important; |
There was a problem hiding this comment.
It's unfortunate that we are fighting our own alignment and padding rules here.
There was a problem hiding this comment.
yeah, I thought the same, and I don't think it's the first time I've butted heads with this particular code. I'll have to think about it.
| margin-left: auto !important; | ||
| margin-right: auto !important; | ||
| padding: 0; | ||
| column-gap: 0; |
There was a problem hiding this comment.
I would be nice to be able to specify this gap value from theme.json, because it's a bit arbitrary right now (0.5em for any flex layouts).
There was a problem hiding this comment.
yeah, GB should provide a setting for this
There was a problem hiding this comment.
Apparently it's planned: WordPress/gutenberg#33359
|
I'm holding on to this one because the gap control looks like it may make it soon and I still want to check if we can improve the Blockbase rules that we are overriding here |
|
I think this is the change introducing gap that you are talking about: WordPress/gutenberg#33812 Linking so I don't have to go hunting for it again. :P |
|
I kind of thought that it was going to make it sooner, we could deploy this as is and then iterate, right now this PR adds the gap via CSS, we can always come back to remove that and add the new markup |
The footer for Seedlet blocks was broken. This solution leverages flex layout on the group block.
Before:
After: