Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Seedlet blocks: fix broken footer #4360

Merged
MaggieCabrera merged 1 commit into from
Aug 19, 2021
Merged

Seedlet blocks: fix broken footer #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion seedlet-blocks/assets/theme.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 9 additions & 13 deletions seedlet-blocks/block-template-parts/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,18 @@
<div style="height:30px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:group {"className":"footer-credit","layout":{"inherit":false}} -->
<!-- wp:group {"className":"footer-credit","layout":{"type":"flex"}} -->
<div class="wp-block-group footer-credit"><!-- wp:site-title {"level":0} /-->

<!-- wp:paragraph -->
<p>, </p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"align":"left","fontSize":"small"} -->
<p class="has-text-align-left has-small-font-size">Proudly Powered by <a href="https://wordpress.org" rel="nofollow">WordPress</a></p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->
<!-- wp:paragraph -->
<p>, </p>
<!-- /wp:paragraph -->
<!-- wp:paragraph {"align":"left","fontSize":"small"} -->
<p class="has-text-align-left has-small-font-size">Proudly Powered by <a href="https://wordpress.org" rel="nofollow">WordPress</a></p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:spacer {"height":30} -->
<div style="height:30px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
2 changes: 1 addition & 1 deletion seedlet-blocks/block-templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
</div>
<!-- /wp:query -->

<!-- wp:template-part {"slug":"footer","tagName":"footer","layout":{"inherit":true},"className":"site-footer-container"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"footer","layout":{"inherit":true},"className":"site-footer-container","align":"full"} /-->
7 changes: 6 additions & 1 deletion seedlet-blocks/sass/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,14 @@
}

.footer-credit {
display: flex;
font-family: var(--wp--preset--font-family--headings);
white-space: pre-wrap;
&[class*="wp-container-"] {
margin-left: auto !important;
Copy link
Contributor

@jffng jffng Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that we are fighting our own alignment and padding rules here.

Copy link
Contributor Author

@MaggieCabrera MaggieCabrera Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I thought the same, and I don't think it's the first time I've butted heads with this particular code. I'll have to think about it.

margin-right: auto !important;
padding: 0;
column-gap: 0;
Copy link
Contributor

@jffng jffng Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to be able to specify this gap value from theme.json, because it's a bit arbitrary right now (0.5em for any flex layouts).

Copy link
Contributor Author

@MaggieCabrera MaggieCabrera Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, GB should provide a setting for this

Copy link
Contributor Author

@MaggieCabrera MaggieCabrera Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it's planned: WordPress/gutenberg#33359

}
}

.footer-credit > * {
Expand Down
3 changes: 3 additions & 0 deletions seedlet-blocks/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@
}
}
},
"layout": {
"contentSize": "620px"
},
"list": {
"spacing": {
"padding": {
Expand Down