-
Notifications
You must be signed in to change notification settings - Fork 2k
Reader Conversations: Caterpillars + Comment Expansion #17517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
main perf issue is something that happens from the callback chain of data-layer's |
|
After a bunch of research it turns out the biggest perf issue was how the comments selectors were using |
|
I'm going to start breaking up this PR into many much smaller PRs. Its currently a mammoth |
|
Theres a couple more parts to break out, but what i've broken up so far is:
Things still to break out:
Also, we shouldn't implement the high watermark reducer the way done in this PR, it isn't generic enough. |
|
closing b/c #17608 covers everything here. |
This PR seeks to add in the caterpillar + comment expansion behavior for reader conversations.
There are a number of challenges still: