Skip to content

Comments: make the proptypes for comments more consistent #17586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samouri merged 1 commit into from
Aug 29, 2017
Merged

Comments: make the proptypes for comments more consistent #17586

samouri merged 1 commit into from
Aug 29, 2017

Conversation

@samouri
Copy link
Contributor

@samouri samouri commented Aug 29, 2017 •
edited
Loading

I noticed a few inconsistencies with how we were naming identifiers.
This renames:

  1. activeReplyCommentID --> activeReplyCommentId
  2. parentCommentID --> parentCommentId

To Test:

  • make sure there are no more references to the old identifiers in the codebase
  • try to do things with comments from Reader. add new, delete, etc.

@samouri samouri added [Feature] Comments Comments on posts and the admin screen for managing them. [Feature] Reader The reader site on Calypso. labels Aug 29, 2017
@samouri samouri self-assigned this Aug 29, 2017
@matticbot
Copy link
Contributor

matticbot commented Aug 29, 2017

Test live: https://calypso.live/?branch=update/comments/idCapitalization

@matticbot matticbot added the [Size] M Medium sized issue label Aug 29, 2017
@samouri samouri added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2017
@samouri samouri added this to the Reader Conversations Tool milestone Aug 29, 2017
@samouri samouri mentioned this pull request Aug 29, 2017
Closed
bluefuton
bluefuton approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@bluefuton bluefuton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any more occurrences. Test pass and comment functionality still looks good :shipit:

@bluefuton bluefuton added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 29, 2017
@samouri samouri merged commit 306ae48 into master Aug 29, 2017
@alisterscott alisterscott deleted the update/comments/idCapitalization branch February 1, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluefuton bluefuton bluefuton approved these changes

Assignees

@samouri samouri

Labels

[Feature] Comments Comments on posts and the admin screen for managing them. [Feature] Reader The reader site on Calypso. [Size] M Medium sized issue [Type] Janitorial

Projects

None yet

Milestone

Reader Conversations - Launch

Development

Successfully merging this pull request may close these issues.

4 participants

@samouri @matticbot @bluefuton