Skip to content

Conversation

@samouri
Copy link
Contributor

@samouri samouri commented Jan 18, 2018

Consult https://github.com/webpack/webpack/releases for a changelog.
Mostly bugfixes, treeshaking support to require.include, and some other minor changes.

I in particular am interested in this release because it includes a memory leak fix for the Scope Hoisting plugin.

to test
no extensive testing necessary. Just make sure you can still start up and click around in Calypso.

@samouri samouri added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build labels Jan 18, 2018
@samouri samouri self-assigned this Jan 18, 2018
@samouri
Copy link
Contributor Author

samouri commented Jan 18, 2018

@jsnajdr
Copy link
Member

jsnajdr commented Jan 18, 2018

There are some very strange failures in the desktop build: it looks more like broken node_modules directory rather than a problem with this PR. Can you verify that?

Locally building CALYPSO_ENV=desktop npm run build always fails on missing electron package, both in this branch and in master, so I'm probably not building it right.

@dmsnell
Copy link
Member

dmsnell commented Jan 18, 2018

I'm suspicious that because we didn't update the webpack.shared.js file in wp-desktop that it's the source of these errors. maybe we just need to update as was done in https://github.com/Automattic/wp-calypso/pull/21349/files#diff-cb006786d97169a6aa9bff024064ecefR106

@jsnajdr
Copy link
Member

jsnajdr commented Jan 18, 2018

Or it's a build failure unrelated to this PR. I just got exactly the same failure for an unrelated PR #21641.

@samouri
Copy link
Contributor Author

samouri commented Jan 18, 2018

The new sections-loader pr broke the desktop builds which is causing all of the canaries to fail.
I have a PR out now to fix it: Automattic/wp-desktop#405

Locally building CALYPSO_ENV=desktop npm run build always fails on missing electron package, both in this branch and in master, so I'm probably not building it right.

Has that ever worked? I've never tried it

@samouri
Copy link
Contributor Author

samouri commented Jan 18, 2018

@jsnajdr: I was just able to run CALYPSO_ENV=desktop npm run build with no errors in this branch :/

@samouri samouri added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 18, 2018
@samouri samouri merged commit 7330319 into master Jan 18, 2018
@samouri samouri deleted the update/webpack branch January 18, 2018 19:58
@sirreal sirreal removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants