Skip to content

Update calypso to latest, and fix the loaders #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samouri merged 1 commit into from
Jan 18, 2018
Merged

Update calypso to latest, and fix the loaders #405

samouri merged 1 commit into from
Jan 18, 2018

Conversation

@samouri
Copy link
Contributor

@samouri samouri commented Jan 18, 2018 •
edited
Loading

This PR:

  1. updates extensions-loader rule to match wp-calypso's
  2. removes json-loader which isn't needed in the latest versions of webpack
  3. updates the isomorphic-routing loader to use the new sections-loader introduced in Framework: introduce sections middleware wp-calypso#21349
  4. points calypso to to the tip

to test
run npm start

@samouri samouri requested a review from astralbodies January 18, 2018 16:55
@samouri samouri self-assigned this Jan 18, 2018
@samouri samouri mentioned this pull request Jan 18, 2018
Merged
astralbodies
astralbodies approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@astralbodies astralbodies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix @samouri!

@samouri samouri merged commit 26d22b9 into develop Jan 18, 2018
@samouri samouri deleted the fix/sections-loader branch January 18, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@astralbodies astralbodies astralbodies approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samouri samouri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samouri @astralbodies