Skip to content

Publicize Gutenblock: Use Disabled component rather than prop #28723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ockham merged 1 commit into from
Nov 20, 2018
Merged

Publicize Gutenblock: Use Disabled component rather than prop #28723

ockham merged 1 commit into from
Nov 20, 2018

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Nov 20, 2018

Changes proposed in this Pull Request

Use the Disabled component rather than a disabled prop to conditionally wrap FormToggle when the toggleable attribute is false. This should style the toggles properly when using a Gutenberg branch or version that includes WordPress/gutenberg#12091.

Testing instructions

  • Test with Gutenberg master
  • Start writing a new post
  • Click 'Publish'. Verify that the connection toggles work as before.
  • Publish the post. Verify that it is publicized to the services that were enabled in the pre-publish panel
  • Change the post status back to draft
  • Click 'Publish' again. Verify that all connection toggles are disabled, and that styling looks fine.

@ockham ockham added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Nov 20, 2018
@ockham ockham self-assigned this Nov 20, 2018
@matticbot
Copy link
Contributor

matticbot commented Nov 20, 2018

Test live: https://calypso.live/?branch=update/publicize-gutenblock-use-disabled-component

@ockham ockham requested a review from tyxla November 20, 2018 17:39
tyxla
tyxla approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 🚢

@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2018
@ockham ockham merged commit 3f43630 into master Nov 20, 2018
@ockham ockham deleted the update/publicize-gutenblock-use-disabled-component branch November 20, 2018 18:00
This was referenced Nov 20, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyxla tyxla tyxla approved these changes

Assignees

@ockham ockham

Labels

[Goal] Gutenberg Working towards full integration with Gutenberg Jetpack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ockham @matticbot @tyxla