Skip to content

Publicize Gutenblock: Use Disabled component rather than prop #28723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ockham merged 1 commit into from
Nov 20, 2018
Merged

Publicize Gutenblock: Use Disabled component rather than prop #28723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions client/gutenberg/extensions/publicize/connection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* External dependencies
*/
import { Component } from '@wordpress/element';
import { FormToggle } from '@wordpress/components';
import { Disabled, FormToggle } from '@wordpress/components';

class PublicizeConnection extends Component {
onConnectionChange = () => {
Expand All @@ -25,6 +25,19 @@ class PublicizeConnection extends Component {
// Genericon names are dash separated
const socialName = name.replace( '_', '-' );

let toggle = (
<FormToggle
id={ fieldId }
className="jetpack-publicize-connection-toggle"
checked={ enabled }
onChange={ this.onConnectionChange }
/>
);

if ( ! toggleable ) {
toggle = <Disabled>{ toggle }</Disabled>;
}

return (
<li>
<div className="publicize-jetpack-connection-container">
Expand All @@ -36,13 +49,7 @@ class PublicizeConnection extends Component {
/>
<span>{ display_name }</span>
</label>
<FormToggle
id={ fieldId }
className="jetpack-publicize-connection-toggle"
checked={ enabled }
onChange={ this.onConnectionChange }
disabled={ ! toggleable }
/>
{ toggle }
</div>
</li>
);
Expand Down