-
Notifications
You must be signed in to change notification settings - Fork 2k
Users management: Include Viewer role in the team members list #72266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d85d087 to
cd0ae48
Compare
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~385 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
zaerl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it and everything is working using the Jetpack PR. 🚢
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7757367 Thank you @bogiii for including a screenshot in the description! This is really helpful for our translators. |
|
Translation for this Pull Request has now been finished. |
Proposed Changes
For the code review, follow commit by commit; it will be more convenient.
Testing Instructions
The Follower member type will not be presented since the BE endpoint is not deployed yet, you can follow it in the PR.
The good thing, these changes can be applied/deployed, and nothing will be changed against the current app state.
Scenario 1:
/people/team/{SITE}Scenario 2:
/people/team/{SIMPLE_SITE}/people/viewers/{SITE}/{USER_ID}Screenshots
Pre-merge Checklist
Closes #72000