Skip to content

update all dependencies #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2023
Merged

update all dependencies #92

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
503b300
update all dependencies
gambtho Aug 31, 2023
6db57fa
import order
gambtho Aug 31, 2023
982e525
add explanation for dockerfile
gambtho Aug 31, 2023
3f8bbe3
remove redundant test
gambtho Aug 31, 2023
a7b5854
Merge branch 'main' into thgamble/depbump2
gambtho Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redundant test
  • Loading branch information
@gambtho
gambtho committed Aug 31, 2023
commit 3f8bbe3abb3aa24b34719b9e27cfe01006c36a75
39 changes: 0 additions & 39 deletions pkg/controller/common/resource_reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,42 +143,3 @@ func TestResourceReconciler_DeletionTimestamp(t *testing.T) {
errors.IsNotFound(c.Get(context.Background(), client.ObjectKeyFromObject(obj), actual)),
"expected not found error")
}

func TestResourceReconciler_Start(t *testing.T) {
deletionTimeStamp := metav1.NewTime(time.Now().Add(1 * time.Second))
obj := &corev1.Namespace{

TypeMeta: metav1.TypeMeta{
Kind: "Namespace",
APIVersion: "v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test",
DeletionTimestamp: &deletionTimeStamp,
Finalizers: []string{"finalizer"},
},
}

c := fake.NewClientBuilder().WithObjects(obj).Build()

rr := &resourceReconciler{
name: controllername.New("test", "name"),
client: c,
logger: logr.Discard(),
resources: []client.Object{obj},
}

obj.SetFinalizers([]string{})
require.NoError(t, c.Update(context.Background(), obj))

ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond)
defer cancel()
// err in this case will be "context deadline exceeded"
_ = rr.Start(ctx)

// resource should be removed
actual := &corev1.Namespace{}
require.True(t,
errors.IsNotFound(c.Get(context.Background(), client.ObjectKeyFromObject(obj), actual)),
"expected not found error")
}