Support Pricing Tier #1749
Merged
Support Pricing Tier #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
spring-cloud |
qwordy
reviewed
May 25, 2020
qwordy
reviewed
May 25, 2020
Member
|
You may need add test cases since you add new commands |
| c.argument('location', arg_type=get_location_type( | ||
| self.cli_ctx), validator=validate_location) | ||
| c.argument('location', arg_type=get_location_type(self.cli_ctx), validator=validate_location) | ||
| c.argument('sku', type=str, validator=validate_sku, help='Name of SKU, the value is "Basic" or "Standard"') |
Member
There was a problem hiding this comment.
Why not use get_enum_type for sku?
Contributor
Author
There was a problem hiding this comment.
is it able to customize the CLI error in get_enum_type?
raise CLIError("The pricing tier only accept value [Basic, Standard]")
Member
There was a problem hiding this comment.
The error message of get_enum_type cannot be customized and will tell users to see --help for the allowed values.
Comment on lines
+18
to
+20
| g.custom_command('create', 'spring_cloud_create', supports_no_wait=True) | ||
| g.custom_command('update', 'spring_cloud_update', supports_no_wait=True) | ||
| g.custom_command('delete', 'spring_cloud_delete', supports_no_wait=True) |
Member
There was a problem hiding this comment.
Need to add g.wait_command.
fengzhou-msft
approved these changes
Jun 9, 2020
qwordy
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.