-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support Pricing Tier #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support Pricing Tier #1749
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cbc6dd2
update swagger
1openwindow e612d1a
add pricing tier in CLI
1openwindow 18cd0f2
remove validation when create app
1openwindow 9dbaa32
fix style issue
1openwindow eb8fd2c
update python sdk
1openwindow 17c20cc
Merge branch 'upstream/master' into zihch/support-sku
1openwindow ae5d346
change syntax
1openwindow 1540843
Merge branch 'upstream/master' into zihch/support-sku
1openwindow 6ff02a1
update help example
1openwindow 24de688
remove location
1openwindow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,14 +15,11 @@ | |
| # pylint: disable=too-many-statements | ||
| def load_command_table(self, _): | ||
| with self.command_group('spring-cloud', client_factory=cf_app_services) as g: | ||
| g.custom_command('create', 'spring_cloud_create', | ||
| supports_no_wait=True) | ||
| g.custom_command('delete', 'spring_cloud_delete', | ||
| supports_no_wait=True) | ||
| g.custom_command('list', 'spring_cloud_list', | ||
| table_transformer=transform_spring_cloud_table_output) | ||
| g.custom_show_command('show', 'spring_cloud_get', | ||
| table_transformer=transform_spring_cloud_table_output) | ||
| g.custom_command('create', 'spring_cloud_create', supports_no_wait=True) | ||
| g.custom_command('update', 'spring_cloud_update', supports_no_wait=True) | ||
| g.custom_command('delete', 'spring_cloud_delete', supports_no_wait=True) | ||
|
Comment on lines
+18
to
+20
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to add |
||
| g.custom_command('list', 'spring_cloud_list', table_transformer=transform_spring_cloud_table_output) | ||
| g.custom_show_command('show', 'spring_cloud_get', table_transformer=transform_spring_cloud_table_output) | ||
|
|
||
| with self.command_group('spring-cloud test-endpoint', client_factory=cf_spring_cloud) as g: | ||
| g.custom_command('enable ', 'enable_test_endpoint') | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
get_enum_typefor sku?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it able to customize the CLI error in get_enum_type?
raise CLIError("The pricing tier only accept value [Basic, Standard]")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message of get_enum_type cannot be customized and will tell users to see --help for the allowed values.