Skip to content

Conversation

@marwanad
Copy link
Contributor

@marwanad marwanad commented Aug 6, 2020


PR: Azure/azure-cli#14344 introduced a breaking change to azure-mgmt-resource which broke compatibility of the AKS CLI-extension with the latest CLI core.

This is based off the changes to preserve backwards compatibility in PR: ttps://github.com/Azure/azure-cli/pull/14344

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/marwanad/azure-cli-extensions.git@fix-mgmt-sdk-regression#subdirectory=src/$EXT&egg=$EXT"

Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arrownj
Copy link
Contributor

arrownj commented Aug 6, 2020

Add @zhoxing-ms who is responsible for Resource module to review this.

@arrownj arrownj requested a review from zhoxing-ms August 6, 2020 02:29
@arrownj arrownj self-assigned this Aug 6, 2020
@zhoxing-ms
Copy link
Contributor

@marwanad Hi, the code is fine, could you pelase re-run the deployment related tests in live mode? This can further ensure that the modification is correct

@marwanad
Copy link
Contributor Author

marwanad commented Aug 6, 2020

@zhoxing-ms
I validated locally using:

az aks create --enable-addons monitoring

which was the command failing with latest CLI and extensions.

I don't think the existing live tests in extensions exercise that scenario. I can look into adding this test case in a separate PR.

Are the extension live recordings run frequently or is it only the CLI core ones that are run daily?

@zhoxing-ms
Copy link
Contributor

@marwanad We always re-record yaml file through live test when the code has some change in the logic. In addition, we also have regular live test tasks for the CLI main repo.

If you can ensure that all the deployment related parts in this extension are modified correctly, it is feasible to supplement the relevant tests with a separate PR, so I think this PR can be passed~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants