Skip to content

{ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 #14344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yonzhan merged 1 commit into from
Jul 28, 2020
Merged

{ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 #14344

yonzhan merged 1 commit into from
Jul 28, 2020

Conversation

@zhoxing-ms
Copy link
Contributor

@zhoxing-ms zhoxing-ms commented Jul 14, 2020 •
edited
Loading

Description

Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01
For PR: #13429 #14241
At the same time, some compatibility logic was made for the breaking change of SDK to ensure that breaking will not be produced on the CLI side, such as: click

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan added this to the S173 milestone Jul 14, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 14, 2020

add to S173

@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch from 80a33c2 to ec4016c Compare July 15, 2020 01:58
qwordy
qwordy approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@qwordy qwordy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with vm module

@zhoxing-ms zhoxing-ms changed the title {ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 WIP {ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 Jul 15, 2020
@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch 3 times, most recently from ca579f1 to ebcd759 Compare July 20, 2020 11:26
@zhoxing-ms zhoxing-ms changed the title WIP {ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 {ARM} Bump azure-mgmt-resource from v2019-07-01 to v2020-06-01 Jul 20, 2020
haroldrandom
haroldrandom reviewed Jul 21, 2020
View reviewed changes
src/azure-cli/azure/cli/command_modules/network/custom.py Outdated
Copy link
Contributor

@haroldrandom haroldrandom Jul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a breaking change?

Copy link
Contributor Author

@zhoxing-ms zhoxing-ms Jul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a breaking change of SDK, and we did made some compatibility logic to ensure that the CLI will not be broken

@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch 2 times, most recently from 3f167be to aac6ad8 Compare July 21, 2020 09:02
@detienne20 detienne20 mentioned this pull request Jul 21, 2020
Merged
@shenglol shenglol mentioned this pull request Jul 21, 2020
Closed
2 tasks
@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch 4 times, most recently from 47b21b8 to 2374d54 Compare July 24, 2020 03:39
zhoxing-ms
zhoxing-ms commented Jul 24, 2020
View reviewed changes
src/azure-cli/azure/cli/command_modules/resource/custom.py Outdated
Comment on lines 436 to 472
Copy link
Contributor Author

@zhoxing-ms zhoxing-ms Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility logic for breaking change from SDK

mmyyrroonn
mmyyrroonn approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for monitor commands

Juliehzl
Juliehzl approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for storage part

@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch 6 times, most recently from d7b4f58 to 515ac0d Compare July 24, 2020 15:15
v-Ajnava
v-Ajnava approved these changes Jul 27, 2020
View reviewed changes
Copy link

@v-Ajnava v-Ajnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Eventhub and Servicebus

arrownj
arrownj approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For VM module, it's good.

@zhoxing-ms
Copy link
Contributor Author

zhoxing-ms commented Jul 27, 2020

@samkreter Could you please help to review this PR for your part~

jsntcy
jsntcy reviewed Jul 27, 2020
View reviewed changes
src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/export_features_prop.json Outdated
Copy link
Member

@jsntcy jsntcy Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comments affect test result? #Closed

Copy link
Contributor Author

@zhoxing-ms zhoxing-ms Jul 27, 2020 •
edited by jsntcy
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is automatically generated and should not affect the test results #Closed

jsntcy
jsntcy approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch 2 times, most recently from b5dde9b to 3f120b8 Compare July 28, 2020 01:44
@zhoxing-ms zhoxing-ms force-pushed the mgmt-resource-bump-api-version branch from 3f120b8 to a043ea6 Compare July 28, 2020 01:50
@zhoxing-ms
Copy link
Contributor Author

zhoxing-ms commented Jul 28, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 28, 2020

Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan yonzhan merged commit 6185cbb into Azure:dev Jul 28, 2020
@marwanad marwanad mentioned this pull request Aug 6, 2020
Merged
3 tasks
@jiasli jiasli mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiasli jiasli jiasli approved these changes

@jsntcy jsntcy jsntcy approved these changes

@Juliehzl Juliehzl Juliehzl approved these changes

@bgklein bgklein Awaiting requested review from bgklein

@jaredmoo jaredmoo Awaiting requested review from jaredmoo

@qianwens qianwens Awaiting requested review from qianwens

@samkreter samkreter Awaiting requested review from samkreter

+7 more reviewers

@arrownj arrownj arrownj approved these changes

@bim-msft bim-msft bim-msft approved these changes

@qwordy qwordy qwordy approved these changes

@haroldrandom haroldrandom haroldrandom approved these changes

@v-Ajnava v-Ajnava v-Ajnava approved these changes

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

None yet

Projects

None yet

Milestone

S173

Development

Successfully merging this pull request may close these issues.