[AKS] Support updating from SPN cluster to MSI cluster

[norshtein]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[azuresdkci]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it mcr.microsoft.com/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/norshtein/azure-cli-extensions.git@tosi/aks-spn-to-msi#subdirectory=src/$EXT&egg=$EXT"

[norshtein]

The job "Verify Extensions Index" failed with error:

======================================================================
FAIL: test_metadata (__main__.TestIndex)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./scripts/ci/test_index.py", line 139, in test_metadata
    self.whl_cache_dir, self.whl_cache)
  File "/home/vsts/work/1/s/scripts/ci/util.py", line 86, in get_whl_from_url
    assert r.status_code == 200, "Request to {} failed with {}".format(url, r.status_code)
AssertionError: Request to https://azurecliprod.blob.core.windows.net/cli-extensions/synapse-0.1.0-py2.py3-none-any.whl failed with 500

The extension the error referencing to is relevant to aks-preview, and I've run python scripts/ci/test_index.py -q locally and succeeded:

$ python scripts/ci/test_index.py -q
----------------------------------------------------------------------
Ran 9 tests in 0.014s

OK (skipped=2)

Anything I can do to fix the CI error?

[arrownj]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[arrownj]

Hi @norshtein , could you please also help add tests for these new parameters ?

[norshtein]

Hi @arrownj , could you add a "Do-Not-Merge" label for this PR? AKS have a server-side behavior change on this feature which will take effect in next week. I will add a recording after the server side change take effect.

[norshtein]

Hi @arrownj , I've added recording for this change and this PR is ready to be merged. Could you please help merge the PR?

By the way, I found in the recording file, the secret of service principal is also recorded as plain text, which might need some awareness. I've deleted affected service principal, but I think some fix in recording system is needed.

[arrownj]

Hi @arrownj Xiaojian Xu FTE , I've added recording for this change and this PR is ready to be merged. Could you please help merge the PR?

By the way, I found in the recording file, the secret of service principal is also recorded as plain text, which might need some awareness. I've deleted affected service principal, but I think some fix in recording system is needed.

Hi @norshtein , actually we can add some custom replacer while initializing a ScenarioTest. The framework has define some common used Replacer, you can read GraphClientPasswordReplacer for example. It is used in the ScenarioTest construct function. For your case, you can add a customized Replacer and add it in your ScenarioTest subclass. And if it is general enough, we can also consider add it in the test framework.

[norshtein]

@arrownj thanks for the explanation, it helps!