[AKS] Support updating from SPN cluster to MSI cluster #17902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norshtein
requested review from
fengzhou-msft,
jsntcy,
kairu-ms and
zqingqing1
as code owners
norshtein
force-pushed
the
tosi/migrate-from-spn-to-msi
branch
from
05198f1 to
c7bd8f7
Compare
Member
Author
|
Rebased on latest dev branch. |
norshtein
force-pushed
the
tosi/migrate-from-spn-to-msi
branch
from
c7bd8f7 to
8d8bb7a
Compare
Member
Author
|
Rebased on latest dev branch again. |
fengzhou-msft
approved these changes
Apr 28, 2021
Member
fengzhou-msft
left a comment
fengzhou-msft
left a comment
There was a problem hiding this comment.
For managed identity options, the recommendation design is here.
Approve as the same options are already in aks create and the same change released in aks-preview. It is by design that aks update does not support removing a managed identity.
jsntcy
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the implementation for supporting updating from SPN cluster to MSI cluster. The feature has been in preview state for a while, and we're going to GA it. The PR is a combination of following two PRs in aks-preview extension:
Testing Guide
History Notes
[AKS] Support updating from SPN cluster to MSI cluster.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.