{Core} hotfix the name of extension of dev type is None if it has incompatibility problem with core #12598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroldrandom
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
jiasli and
qianwens
as code owners
Collaborator
|
add to S167 |
haroldrandom
changed the title
haroldrandom
changed the title
haroldrandom
changed the title
fengzhou-msft
approved these changes
Mar 18, 2020
jiasli
approved these changes
Mar 18, 2020
mmyyrroonn
approved these changes
Mar 18, 2020
haroldrandom
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary hotfix the name not found problem when an extension has incompatibility problem.
Fix #12597
Background:
CLI and extension currently relies on metadata.json to load/record meta info, which is generated from wheel <= 0.30.0 while packaging. However it's buggy and wheel starting from 0.32.0, has removed the metadata.json as wheel.
Also, src/index.json use that that to update. and azdev and extension release pipeline
So, we cannot upgrade wheel for now until we decide to migrate metadata infrastructure. It takes a big effort
That's why I named the PR title "hotfix". It involves how we extract metadata from Python package considering breaking changes of wheel. It's a small step of upgrade wheel.
Additional context
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.