-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Core] Use pkginfo to query metadata for Python Package #12782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+13
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
453a360 to
b2f025e
Compare
Collaborator
|
add to S168 |
3 tasks
Member
|
Please fix typos in the PR title as it directly goes into the release history. Use capitalized "Unpin". Also, some test commands for Testing Guide section and unit tests will be helpful. |
jiasli
reviewed
Mar 30, 2020
Contributor
Author
added |
jiasli
approved these changes
Apr 7, 2020
fengzhou-msft
approved these changes
Apr 10, 2020
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR (Mandatory)
The original purpose to pin wheel version is that it requires a big effort to deal with the breaking changes of wheel from 0.30.0 to 0.31.0 and lack of resources back then (#8896).
Now it's time to unpin wheel version as user request, deprecating old way to query metadata of Python Package.
Using pkginfo to query metadata for Python Package to meet Python Core Metadata Specification. ( PEP 241, PEP 314, PEP 345, PEP 566).
azdev and Azure/azure-cli-extensions have already catch up to change:
Related PRs and issues:
This also fix bug in some scenarios that CLI can not load metadata of dev typle extension, like
az extension list -o tablein extensioninteractive.Testing Guide
Prepare 3 Python version 3.6, 3.7, 3.8 as first.
Wheel type extension
choose some extensions and build them via bdist_wheel or
azdev extension buildwith wheel 0.30.0, 0.31.0, 0.32.0, 0.33.0, 0.34.2, install them byaz extension add -s {wheel_filepath}Dev type extension
choose some extensions and add them directly in development/editable mode via
azdev extension add {extension_name}after setup.then test to show extension/other az commmand udner 3 Python verions respectively.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.