Skip to content

Conversation

@haroldrandom
Copy link
Contributor

@haroldrandom haroldrandom commented Mar 30, 2020

Description of PR (Mandatory)
The original purpose to pin wheel version is that it requires a big effort to deal with the breaking changes of wheel from 0.30.0 to 0.31.0 and lack of resources back then (#8896).

Now it's time to unpin wheel version as user request, deprecating old way to query metadata of Python Package.
Using pkginfo to query metadata for Python Package to meet Python Core Metadata Specification. ( PEP 241, PEP 314, PEP 345, PEP 566).

azdev and Azure/azure-cli-extensions have already catch up to change:

Related PRs and issues:

This also fix bug in some scenarios that CLI can not load metadata of dev typle extension, like az extension list -o table in extension interactive.

Testing Guide

Prepare 3 Python version 3.6, 3.7, 3.8 as first.

Wheel type extension

choose some extensions and build them via bdist_wheel or azdev extension build with wheel 0.30.0, 0.31.0, 0.32.0, 0.33.0, 0.34.2, install them by az extension add -s {wheel_filepath}

Dev type extension

choose some extensions and add them directly in development/editable mode via azdev extension add {extension_name} after setup.

then test to show extension/other az commmand udner 3 Python verions respectively.


This checklist is used to make sure that common guidelines for a pull request are followed.

@haroldrandom haroldrandom added the Extensions `az extension` commands or extension infrastructure label Mar 30, 2020
@haroldrandom haroldrandom self-assigned this Mar 30, 2020
@yonzhan yonzhan added this to the S168 milestone Mar 30, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 30, 2020

add to S168

@jiasli
Copy link
Member

jiasli commented Mar 30, 2020

Please fix typos in the PR title as it directly goes into the release history. Use capitalized "Unpin".

Also, some test commands for Testing Guide section and unit tests will be helpful.

@haroldrandom haroldrandom changed the title [extension] unpin wheel version via pkginfo to query metadata for Python Package and {Core} Unpin wheel version via pkginfo to query metadata for Python Package Mar 30, 2020
@haroldrandom haroldrandom added the Core CLI core infrastructure label Mar 30, 2020
@haroldrandom
Copy link
Contributor Author

Please fix typos in the PR title as it directly goes into the release history. Use capitalized "Unpin".

Also, some test commands for Testing Guide section and unit tests will be helpful.

added

@yonzhan yonzhan modified the milestones: S168, S169 - For Build Apr 18, 2020
@haroldrandom haroldrandom changed the title {Core} Unpin wheel version via pkginfo to query metadata for Python Package [Core] Unpin wheel version via pkginfo to query metadata for Python Package Apr 22, 2020
@haroldrandom haroldrandom merged commit 44c3b4a into Azure:dev Apr 27, 2020
@haroldrandom haroldrandom deleted the unpin-wheel branch April 27, 2020 07:48
@haroldrandom haroldrandom changed the title [Core] Unpin wheel version via pkginfo to query metadata for Python Package [Core] use pkginfo to query metadata for Python Package Apr 27, 2020
@haroldrandom haroldrandom changed the title [Core] use pkginfo to query metadata for Python Package [Core] Use pkginfo to query metadata for Python Package Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core CLI core infrastructure Extensions `az extension` commands or extension infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove azure-cli-core wheel==0.30 wheel pin Make extensions compatible with latest versions of wheel

4 participants