-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[CosmosDB] Allow creating fixed collections #13950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
add to S171 |
Contributor
Author
|
@Juliehzl please have a look |
Juliehzl
approved these changes
Jun 17, 2020
MehaKaushik
added a commit
to MehaKaushik/azure-cli
that referenced
this pull request
Jun 18, 2020
* {Docs} Remove stale reference in README to closed issue about extensions (Azure#12771)
* Making shard key optional, to allow fixed collections
Co-authored-by: Daniel Miller <[email protected]>
Co-authored-by: Azure CLI Team <[email protected]>
Co-authored-by: Meha Kaushik <[email protected]>
Juliehzl
pushed a commit
that referenced
this pull request
Jul 7, 2020
…ableAnalyticalStorage (#13985) * updated sdk version * replaced ipRangeFilter by IpRules * fixing IpRules * Added autoscale related changes * tests for autoscale * Changes for ip_rules * init for updates in database account properties * final changes and tests for enableFreeTier, serverVersion and enableAnalyticalStorage * error message * added analytical ttl in mongo collection * fixes * analytical_storage_ttl in cassandra table * updated all tests * [CosmosDB] Allow creating fixed collections (#13950) * {Docs} Remove stale reference in README to closed issue about extensions (#12771) * Making shard key optional, to allow fixed collections Co-authored-by: Daniel Miller <[email protected]> Co-authored-by: Azure CLI Team <[email protected]> Co-authored-by: Meha Kaushik <[email protected]> * Cherrypicking latest master CosmosDB * adding exists command to databases and collections * update descriptions of throughput parameter * re-run tests Co-authored-by: Sam Hurd <[email protected]> * updated tests * fixing lint issue * fixing style check * Addressed comments * Removed preview tag from RuntimeResources * fixing cosmosdb in network * Fixing cosmosdb network tests * missed private_endpint_connection yaml * missed private_endpint_connection yaml * re-added network tests * re-running tests * fixture for CI * changes to address github issue 14191 * nit * addressed PR comments * re-ran the network tests for cosmosdb * lint fix * re-added network module tests * addressed comment Co-authored-by: Meha Kaushik <[email protected]> Co-authored-by: Daniel Miller <[email protected]> Co-authored-by: Azure CLI Team <[email protected]> Co-authored-by: shurd <[email protected]> Co-authored-by: Sam Hurd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are making shard key as an optional parameter in create cosmosdb mongodb collection. This will allow users to create fixed collections.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.