Skip to content

[CosmosDB] Recent features: Autoscale, IpRules, EnableFreeTier and EnableAnalyticalStorage #13985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Juliehzl merged 36 commits into from
Jul 7, 2020
Merged

[CosmosDB] Recent features: Autoscale, IpRules, EnableFreeTier and EnableAnalyticalStorage #13985

Juliehzl merged 36 commits into from
Jul 7, 2020

Conversation

@MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented Jun 17, 2020 •
edited
Loading

Description
This PR introduces:

  1. Autoscale related changes i.e. wherever user can provide throughput , now user can provide max-throughput.
  2. Account properties which are updated:
    a. IpRangeFilter changed to IpRules, IpRules is an array of strings.
    b. EnableFreeTier, EnableAnalyticalStorage added.
  3. Mongo Collection and Cassandra Table have AnalyticalStorageTTL as a param.

Testing Guide
Unit tests and manual testing

History Notes

[Component Name 1] BREAKING CHANGE: az cosmosdb account create, az cosmosdb account update

This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan added this to the S171 milestone Jun 17, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 17, 2020

CosmosDB

@MehaKaushik MehaKaushik marked this pull request as ready for review June 17, 2020 22:28
@MehaKaushik MehaKaushik marked this pull request as draft June 17, 2020 22:31
@MehaKaushik MehaKaushik marked this pull request as ready for review June 18, 2020 18:32
MehaKaushik and others added 4 commits June 18, 2020 12:56
@MehaKaushik @dkmiller @azclibot
[CosmosDB] Allow creating fixed collections (Azure#13950)
7a8cfab 
* {Docs} Remove stale reference in README to closed issue about extensions (Azure#12771)

* Making shard key optional, to allow fixed collections

Co-authored-by: Daniel Miller <[email protected]>
Co-authored-by: Azure CLI Team <[email protected]>
Co-authored-by: Meha Kaushik <[email protected]>
@shurd
Cherrypicking latest master CosmosDB
40beea1 
* adding exists command to databases and collections

* update descriptions of throughput parameter

* re-run tests

Co-authored-by: Sam Hurd <[email protected]>
updated tests
d5be0d4
Merge upstream/dev
abd4c7c
@yonzhan yonzhan removed this from the S171 milestone Jun 20, 2020
@mmyyrroonn
Copy link
Contributor

mmyyrroonn commented Jul 1, 2020

@myronfanqiu made changes to fix the tests.
@Juliehzl please approve and merge, if it looks good to you.

Well. Won't server return description?

No it doesn't

I see. Approved. Just want to know the context, is there any reason to hide this field? Generally, other services would return this field. Based on our discussion with Network team, private link scenario should be same across different services.

I don't own this part of our service, I can follow up. If it is how it should be, I can push to get it done. Let me know what you think.

According to our discussion with Network team, I think server should return this field as well. You can double check with Network team as well.

@MehaKaushik
Copy link
Contributor Author

MehaKaushik commented Jul 2, 2020

I have commented the network tests from CosmosDB as well as Network module bcz of this issue: #14194

Will add it back in a future PR, once the issue with Network module is fixed.

@MehaKaushik
Copy link
Contributor Author

MehaKaushik commented Jul 2, 2020 •
edited
Loading

@Juliehzl please approve and merge my PR. We are hoping to get it checked in before 7/8

@MehaKaushik MehaKaushik linked an issue Jul 2, 2020 that may be closed by this pull request
Cosmosdb collection create command should support partition key version field #14191
Closed
@MehaKaushik MehaKaushik mentioned this pull request Jul 2, 2020
Closed
@MehaKaushik
Copy link
Contributor Author

MehaKaushik commented Jul 4, 2020

Ping @Juliehzl

Juliehzl
Juliehzl reviewed Jul 6, 2020
View reviewed changes
Juliehzl
Juliehzl reviewed Jul 6, 2020
View reviewed changes
Juliehzl
Juliehzl reviewed Jul 6, 2020
View reviewed changes
Juliehzl
Juliehzl reviewed Jul 6, 2020
View reviewed changes
Juliehzl
Juliehzl reviewed Jul 6, 2020
View reviewed changes
@MehaKaushik
Copy link
Contributor Author

MehaKaushik commented Jul 7, 2020

@Juliehzl I have addressed the comments, please have another look. I havent pushed the updated tests, doing them in few hours.

@Juliehzl Juliehzl merged commit 4aee466 into Azure:dev Jul 7, 2020
@shurd shurd mentioned this pull request Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

@qianwens qianwens Awaiting requested review from qianwens

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@haroldrandom haroldrandom Awaiting requested review from haroldrandom

+2 more reviewers

@shurd shurd shurd left review comments

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Juliehzl Juliehzl

Labels

None yet

Projects

None yet

Milestone

S172

Development

Successfully merging this pull request may close these issues.

Cosmosdb collection create command should support partition key version field

5 participants

@MehaKaushik @yonzhan @Juliehzl @mmyyrroonn @shurd