[AppService]: fix #14684- access-restriction remove by ip address does not work; #13837-az webapp create - Example for different RSgroups for Plan and WebApp #14818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hi @qwordy , could you pls review this PR? thanks |
yungezz
approved these changes
Aug 18, 2020
panchagnula
reviewed
Aug 18, 2020
panchagnula
suggested changes
Aug 18, 2020
Contributor
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
LGTM - just a few changes
qwordy
approved these changes
Aug 19, 2020
Kotasudhakarreddy
requested review from
bim-msft,
haroldrandom and
mmyyrroonn
as code owners
Kotasudhakarreddy
changed the title
qwordy
reviewed
Aug 26, 2020
qwordy
suggested changes
Aug 26, 2020
Member
qwordy
left a comment
qwordy
left a comment
There was a problem hiding this comment.
I suggest create a subclass in appservice and set the new default value. This class is Azure CLI level. It is used everywhere.
bim-msft
suggested changes
Sep 4, 2020
qwordy
reviewed
Sep 7, 2020
...azure/cli/command_modules/appservice/tests/latest/test_webapp_access_restriction_commands.py
Outdated
Show resolved
Hide resolved
qwordy
approved these changes
Sep 7, 2020
bim-msft
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14684 , #13837
Before CLI version 2.10.0 it was possible to remove an access-restriction by ip address. After the version checking duplicates over ip address the remove by ip address is not working anymore.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.