Skip to content

[AppService]: fix #14684- access-restriction remove by ip address does not work; #13837-az webapp create - Example for different RSgroups for Plan and WebApp #14818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 9 commits into from
Sep 14, 2020
Merged

[AppService]: fix #14684- access-restriction remove by ip address does not work; #13837-az webapp create - Example for different RSgroups for Plan and WebApp #14818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f34281
fix #14684- access-restriction remove by ip address does not work
Kotasudhakarreddy Aug 18, 2020
bd31c25
Added comment
Kotasudhakarreddy Aug 19, 2020
36be493
Unit test
Kotasudhakarreddy Aug 19, 2020
45373f0
UNitTest issues fixed
Kotasudhakarreddy Aug 19, 2020
c4f8af1
Tests for 14684 and Added help text for WebApp create
Kotasudhakarreddy Aug 25, 2020
4a64c6a
Fixed build issues
Kotasudhakarreddy Aug 25, 2020
0243814
Linting Issue
Kotasudhakarreddy Aug 25, 2020
7470b28
undone RG random_name_length to 75
Kotasudhakarreddy Sep 5, 2020
096f297
addressed Review comments
Kotasudhakarreddy Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,10 @@
- name: Create a web app with an image from a private Azure Container Registry.
text: >
az webapp create -g MyResourceGroup -p MyPlan -n MyUniqueAppName -i myregistry.azurecr.io/docker-image:tag
- name: create a WebApp using shared App Service Plan that is in a different resource group.
text: >
AppServicePlanID=$(az appservice plan show -n SharedAppServicePlan -g MyResourceGroup --query "id" --out tsv)
az webapp create -g MyResourceGroup -p "$AppServicePlanID" -n MyUniqueAppName
"""

helps['webapp create-remote-connection'] = """
Expand Down
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ def validate_asp_sku(cmd, namespace):
def validate_ip_address(cmd, namespace):
if namespace.ip_address is not None:
_validate_ip_address_format(namespace)
_validate_ip_address_existance(cmd, namespace)
# For prevention of adding the duplicate IPs.
if 'add' in cmd.name:
_validate_ip_address_existance(cmd, namespace)


def _validate_ip_address_format(namespace):
Expand Down
Loading