[RDBMS] Hotfix: `az postgres flexible-server create` : Update VnetName to exclude servername and update default region for MySQL #15295

arde0708 · 2020-09-25T02:16:48Z

This PR is a hotfix candidate for the recent Ignite Train. It includes :

Changing Vnet Name and subnet name to exclude server name.( to allow servers to be provisioned with HA enabled )
Change the MySQL default region to West US2 as MySQL Flexservers do not exist in the current default - EASTUS
Update the connection string in the postgres create instance response.
Skip adding special characters in the password
Convert user supplied servername to lower case.

yungezz · 2020-09-25T02:43:34Z

hotfix candidate

yungezz · 2020-09-25T04:41:11Z

hi @rajsell @mjain2 @DaeunYim could you pls review this PR? I cannot add you as reviewers, it need to be in azure-sdk-read team I think

mjain2 · 2020-09-25T06:11:21Z

hi @rajsell @mjain2 @DaeunYim could you pls review this PR? I cannot add you as reviewers, it need to be in azure-sdk-read team I think

@yungezz we've signed off + checks looks green, thanks.

yungezz · 2020-09-25T06:56:43Z

src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_util.py

    # if location is not passed as a parameter or is missing from local context
    if location is None:
-        location = DEFAULT_LOCATION
+        if db_engine == 'postgres':


db_engine.lower()

This is something that we are explicitly passing as lower case from the caller. Line 61 in flexible_server_custom_postgres.py.

could you pls add some test to change the overall change?

For this, we are just changing the default location from eastus to westus2 for MySQL. We already have tests for both MySQL and Postgres SQL creation otherwise.

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

Juliehzl · 2020-09-27T01:37:44Z

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

            if command_group == 'mysql':
-                c.argument('sku_name', options_list=['--sku-name'], validator=mysql_sku_name_validator,
+                c.argument('tier', options_list=['--tier'],
+                           help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized ')


For allowed values. prefer using get_enume_type()

Addressed in the SDK comment.

I mean all allowed values for tier and sku_name. Could we also get the allowed array from sdk?

Yes we do have validators for tier, sku_name, storage size validated by the array from sdk. We will include that for the next train.

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

Juliehzl · 2020-09-27T01:38:51Z

src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py

        # Populate desired parameters
        location, resource_group_name, server_name = generate_missing_parameters(cmd, location, resource_group_name,
-                                                                                 server_name)
+                                                                                 server_name, 'postgres')


please avoid positional arguments here

Juliehzl · 2020-09-27T01:39:26Z

src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py

        return _form_response(user, sku, loc, server_id, host, version,
                              administrator_login_password if administrator_login_password is not None else '*****',
-                              _create_postgresql_connection_string(host, administrator_login_password), firewall_id,
+                              _create_postgresql_connection_string(host, user, administrator_login_password), firewall_id,


avoid positional arguments here

Juliehzl · 2020-09-27T01:41:02Z

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

                           help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized ')
-                c.argument('sku_name', default='Standard_B1ms', options_list=['--sku-name'], validator=mysql_sku_name_validator,
+                c.argument('sku_name', default='Standard_B1ms', options_list=['--sku-name'],
                           help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_B1ms, Standard_D4s_v3 ')


Is it possible to get allowed sku values through SDK?

We have a permanent fix for this in S176 where we fetch the SKU's from the SDK. We are currently removing the validators in the PR as there is a bug in the validator which prevents provisioning servers with certain SKU's

sounds good

Juliehzl · 2020-09-27T01:43:12Z

HI @arde0708, as what I see in the e-mail, you need to fix the issue when creating a new flexible-server with HA in a VNET. May I know how you fix it?

arde0708 · 2020-09-27T05:46:04Z

HI @arde0708, as what I see in the e-mail, you need to fix the issue when creating a new flexible-server with HA in a VNET. May I know how you fix it?

@Juliehzl All those changes are in src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py. Basically, we are removing the servername from the VNET name and subnet Name in all places to address this issue.

Juliehzl · 2020-09-28T01:40:56Z

HI @arde0708
        Aritra De
        FTE, as what I see in the e-mail, you need to fix the issue when creating a new flexible-server with HA in a VNET. May I know how you fix it?
@Juliehzl Zunli Hu FTE All those changes are in src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py. Basically, we are removing the servername from the VNET name and subnet Name in all places to address this issue.

Do you have test for related scenarios? I will recommend to add test cases to prevent potential issues in the future, including sdk changes.

Juliehzl · 2020-09-28T01:45:23Z

In addition, your command interface doesn't align with CLI command guideline. From the command, I have no idea which parameters are required.

See other command:

arde0708 · 2020-09-28T02:36:20Z

In addition, your command interface doesn't align with CLI command guideline. From the command, I have no idea which parameters are required.

See other command:

@Juliehzl Please note that none of the arguments in az postgres flexible-server create are Required. Hence, we dont have any of them marked as required. If the user passes them, we use that. Else, we create a default one for the parameters not passed. as a result, you see the difference.

yungezz · 2020-09-28T02:36:57Z

I would suggest create an another issue to track the interface refinement work. Since this is a hotfix to mitigate immediate customer impact, better be more specific more efficient.

Juliehzl · 2020-09-28T02:51:16Z

Hi @arde0708, to do a quick hotfix, we will help you merge the PR.
But to avoid issues in the future, please add test for all your new commands and arguments. Especially there will be track2 migration in the future.
For command design, I will have some concern for custom easy usage, and we should also align with CLI command guideline.

arde0708 · 2020-09-28T02:52:30Z

HI @arde0708
        Aritra De
        FTE, as what I see in the e-mail, you need to fix the issue when creating a new flexible-server with HA in a VNET. May I know how you fix it?
@Juliehzl Zunli Hu FTE All those changes are in src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py. Basically, we are removing the servername from the VNET name and subnet Name in all places to address this issue.
Do you have test for related scenarios? I will recommend to add test cases to prevent potential issues in the future, including sdk changes.

@Juliehzl : This is a temporary patch. The Backend Team is actually fixing the root cause of this issue, but it will be deployed later in October. So this is a patch just until then after which we will revert to what it was.

Juliehzl · 2020-09-28T03:02:21Z

Hi @arde0708, please make sure there is no breaking changes for existing commands and I will merge the PR for hotfix.
Here is to note that All CLI team will be on China National Day holiday from 10.1 ~ 10.8, and we could not support you quickly if there is any furthur issue.

…e to exclude servername and update default region for MySQL (Azure#15295) * hotfix chnages * Remove - from password if thats the first character * Style check fix and Mysql sku * Remove MySQL SKU validator * Remove MySQL SKu and tier validators

* [RDBMS] Hotfix: `az postgres flexible-server create` : Update VnetName to exclude servername and update default region for MySQL (#15295) * hotfix chnages * Remove - from password if thats the first character * Style check fix and Mysql sku * Remove MySQL SKU validator * Remove MySQL SKu and tier validators * {KeyVault} Hotfix: Fix CloudSuffixNotSetException while using `az keyvault` in Azure Stack and Air-Gaped Cloud (#15321) * {Release} Hotfix: Upgrade version to 2.12.1 (#15324) * upgrade version * upgrade version Co-authored-by: arde0708 <[email protected]> Co-authored-by: Feng Zhou <[email protected]>

…PI version from network client. (#15392) * [RDBMS] Hotfix: `az postgres flexible-server create` : Update VnetName to exclude servername and update default region for MySQL (#15295) * hotfix chnages * Remove - from password if thats the first character * Style check fix and Mysql sku * Remove MySQL SKU validator * Remove MySQL SKu and tier validators * Trigger checks * Trigger checks with change in PR title * Remove specific API version * Trigger check for PR Title * Trigger check for PR Title * Trigger CI checks * validate with list-skus info * style fixed * move validators to command body to speed up * test code for validator and restored mgmt testcode * minor fix * flexible mgmt mysql test * new test recording files * style fixed, location changed, linter fixed * linter pass Co-authored-by: Daeun Yim <[email protected]>

hotfix chnages

01ea325

yungezz requested review from Juliehzl and fengzhou-msft September 25, 2020 02:43

yungezz added the PostgreSQL label Sep 25, 2020

arde0708 added 3 commits September 24, 2020 20:57

Remove - from password if thats the first character

191ffec

Style check fix and Mysql sku

5c6e0c2

Remove MySQL SKU validator

ddec5f4

DaeunYim approved these changes Sep 25, 2020

View reviewed changes

Remove MySQL SKu and tier validators

3f27c00

mjain2 approved these changes Sep 25, 2020

View reviewed changes

rajsell approved these changes Sep 25, 2020

View reviewed changes

yungezz reviewed Sep 25, 2020

View reviewed changes

yonzhan assigned Juliehzl Sep 25, 2020

yonzhan added this to the S176 milestone Sep 25, 2020

yungezz approved these changes Sep 27, 2020

View reviewed changes

Juliehzl reviewed Sep 27, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/rdbms/_params.py Show resolved Hide resolved

Juliehzl reviewed Sep 27, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/rdbms/_params.py Show resolved Hide resolved

Juliehzl reviewed Sep 27, 2020

View reviewed changes

Juliehzl approved these changes Sep 28, 2020

View reviewed changes

Juliehzl changed the base branch from release to dev September 28, 2020 02:54

Juliehzl changed the base branch from dev to release September 28, 2020 02:56

Juliehzl changed the title ~~[RDBMS] az postgres flexible-server create : Update VnetName to exclude servername and update default region for MySQL~~ [RDBMS] Hotfix: az postgres flexible-server create : Update VnetName to exclude servername and update default region for MySQL Sep 28, 2020

yonzhan merged commit 23801a4 into Azure:release Sep 28, 2020

[RDBMS] Hotfix: az postgres flexible-server create : Update VnetName to exclude servername and update default region for MySQL #15295

[RDBMS] Hotfix: az postgres flexible-server create : Update VnetName to exclude servername and update default region for MySQL #15295

Uh oh!

Conversation

arde0708 commented Sep 25, 2020

Uh oh!

yungezz commented Sep 25, 2020

Uh oh!

yungezz commented Sep 25, 2020

Uh oh!

mjain2 commented Sep 25, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arde0708 Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Juliehzl commented Sep 27, 2020

Uh oh!

arde0708 commented Sep 27, 2020

Uh oh!

Juliehzl commented Sep 28, 2020

Uh oh!

Juliehzl commented Sep 28, 2020

Uh oh!

arde0708 commented Sep 28, 2020

Uh oh!

yungezz commented Sep 28, 2020

Uh oh!

Juliehzl commented Sep 28, 2020

Uh oh!

arde0708 commented Sep 28, 2020

Uh oh!

Juliehzl commented Sep 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[RDBMS] Hotfix: `az postgres flexible-server create` : Update VnetName to exclude servername and update default region for MySQL #15295

[RDBMS] Hotfix: `az postgres flexible-server create` : Update VnetName to exclude servername and update default region for MySQL #15295

arde0708 Sep 25, 2020 •

edited

Loading