[RDBMS] Bugfix: az postgres flexible-server create Remove hardcoded API version from network client. #15392
Conversation
…e to exclude servername and update default region for MySQL (Azure#15295) * hotfix chnages * Remove - from password if thats the first character * Style check fix and Mysql sku * Remove MySQL SKU validator * Remove MySQL SKu and tier validators
arde0708
changed the title
|
RDBMS |
| def network_client_factory(cli_ctx): | ||
| from azure.mgmt.network import NetworkManagementClient | ||
| return get_mgmt_service_client(cli_ctx, NetworkManagementClient, api_version="2018-08-01") | ||
| return get_mgmt_service_client(cli_ctx, ResourceType.MGMT_NETWORK) |
There was a problem hiding this comment.
actually you even don't need to define it here. network module already has the definition and you could just import it.
| help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_B1ms, Standard_D4s_v3 ') | ||
| c.argument('storage_mb', default='10', options_list=['--storage-size'], type=int, validator=mysql_storage_validator, | ||
| help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_B1ms, Standard_E16ds_v4 ') | ||
| c.argument('storage_mb', default='10', options_list=['--storage-size'], type=int, |
There was a problem hiding this comment.
| c.argument('storage_mb', default='10', options_list=['--storage-size'], type=int, | |
| c.argument('storage_mb', default=10, options_list=['--storage-size'], type=int, |
because it is int type.
| c.argument('backup_retention', default=7, type=int, options_list=['--backup-retention'], | ||
| help='The number of days a backup is retained. Range of 7 to 35 days. Default is 7 days.', | ||
| validator=retention_validator) | ||
| c.argument('version', default='12', options_list=['--version'], |
There was a problem hiding this comment.
quick question: how can user know which kind of version is accepted？
There was a problem hiding this comment.
quick question: how can user know which kind of version is accepted？
Do you mean how they can find out which are the valid versions ?
There was a problem hiding this comment.
If they pass in a wrong value, they will get a Validation error with the set of acceptable values.
| if command_group == 'mysql': | ||
| c.argument('tier', options_list=['--tier'], | ||
| help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized ') | ||
| help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized') |
There was a problem hiding this comment.
still prefer getting allowed value from SDK
| help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized') | ||
| c.argument('sku_name', options_list=['--sku-name'], | ||
| help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_B1ms, Standard_D4s_v3 ') | ||
| help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_B1ms, Standard_E16ds_v4 ') |
| c.argument('storage_mb', options_list=['--storage-size'], type=int, | ||
| validator=mysql_storage_validator, | ||
| help='The storage capacity of the server. Minimum is 5 GiB and increases in 1 GiB increments. Max is 16 TiB.') | ||
| c.argument('backup_retention', type=int, options_list=['--backup-retention'], |
There was a problem hiding this comment.
Here is to define the retention days but how could I enable/disable delete retention?
There was a problem hiding this comment.
It cannot be disabled. By default it is 7 days. But user can pass a value and override the default value.
| c.argument('tier', options_list=['--tier'], | ||
| help='Compute tier of the server. Accepted values: Burstable, GeneralPurpose, Memory Optimized') | ||
| c.argument('sku_name', options_list=['--sku-name'], | ||
| help='The name of the compute SKU. Follows the convention Standard_{VM name}. Examples: Standard_D4s_v3 ') | ||
| c.argument('storage_mb', options_list=['--storage-size'], type=int, | ||
| validator=pg_storage_validator, | ||
| help='The storage capacity of the server. Minimum is 32 GiB and max is 16 TiB.') | ||
| c.argument('backup_retention', type=int, options_list=['--backup-retention'], | ||
| help='The number of days a backup is retained. Range of 7 to 35 days. Default is 7 days.', validator=retention_validator) |
There was a problem hiding this comment.
you have so many duplicate arguments. could you use CLIArgumentType to abstract them and reuse these type.
| c.ignore('location') | ||
| c.ignore('sku_name') | ||
| c.ignore('tier') |
There was a problem hiding this comment.
The three arguments are totally removed in existing command?
There was a problem hiding this comment.
We are not using these three args for the command currently
4 participants
The 'az postgres flexible-server create' command fails with an error as reported in the issue. It happens only when CLI is installed through the installer.
This PR just removes that hardcoded API version.
https://github.com/MicrosoftDocs/azure-docs/issues/63318