{Homebrew} Hotfix: Build with template to revert to python 3.8 #15482
Conversation
|
|
||
| livecheck do | ||
| url "https://github.com/Azure/azure-cli/releases/latest" | ||
| regex(%r{href=.*?/tag/azure-cli[._-]v?(\d+(?:\.\d+)+)["' >]}i) |
There was a problem hiding this comment.
Can we add some comments about what this regex does?
There was a problem hiding this comment.
It's added by Homebrew team, seems to parsing the version number from https://github.com/Azure/azure-cli/releases/latest and then do livecheck.
Valid concern, based on their migration plan: Homebrew/homebrew-core#62201, they only test whether the formula can be installed locally. I added a comment to let them know Azure CLI is not compatible with Python 3.9. |
yungezz
left a comment
yungezz
left a comment
There was a problem hiding this comment.
hi @fengzhou-msft could you pls help to follow up how to get change nofitication on homebrew, we met surprise twice in past releases. It will be helpful if we could get earlier notification.
The change is made through PRs as an open source project. They don't have CODEOWNERS in their repository, which is an ideal way to get notified for PRs. |
:( let me comment at the our previous PR to feedback about this. |
5 participants
Description
Homebrew/homebrew-core#62253 migrated to Python 3.9 for Azure CLI, but Azure CLI is not compatible with Python 3.9 yet. ADO has not supported Python 3.9 either and it caused failures when testing homebrew formula, which blocked the release of our packages.
This PR updates the homebrew template to sync the changes with Homebrew master branch except that Python is still 3.8 and build the homebrew formula from the template.
Testing Guide
Tested the changes in
build_testbranch: https://dev.azure.com/azure-sdk/public/_build/results?buildId=570383&view=resultsHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.