{AKS} Update region mapping list for Container Insights to include latest regions #16377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
AKS |
Member
Author
Member
Author
|
@fengzhou-msft Please take a look at this PR when you get a chance, it is ready for review. |
fengzhou-msft
approved these changes
Jan 6, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is updating the AKS region to Log Analytics region mapping for the Container Insights service.
Both AKS and Log analytics have added new regions since the last update and this PR makes sure that we don't default to eastus for those new regions and actually map it to its proper location.
Testing Guide
Scenario for testing:
Create an AKS cluster in one of the new regions with monitoring enabled (e.g. make sure the resource group is in a new region like: Norway East)
command ->
az aks create --resource-group myResourceGroup --name myAKSCluster --node-count 1 --enable-addons monitoring
Once this command finishes you should see that monitoring is enabled for this cluster and its sending data to the default norwayeast log analytics workspace.
You can check this by doing an 'az aks show --resource-group myResourceGroup --name myAKSCluster' and checking under the omsagent addon for the log analytics workspace id.
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.