Skip to content

Conversation

@bragi92
Copy link
Member

@bragi92 bragi92 commented Jan 6, 2021

Currently talking across multiple teams to align with one consistent naming experience.

Description

Reverting the changes made in this PR: #16377 since we're currently talking with the LA, AppInsights and Alerts team and bringing consistency to the naming experience for the new regions.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

Currently talking across multiple teams to align with one consistent naming experience.
@bragi92 bragi92 requested a review from fengzhou-msft as a code owner January 6, 2021 18:52
@bragi92
Copy link
Member Author

bragi92 commented Jan 6, 2021

@fengzhou-msft Reverting the changes made in this PR: #16377 since the shortcode mapping list I was following was not consistent. I'll create another PR to update this with the new regions once we have a consistent naming convention.

@Azure Azure deleted a comment from yonzhan Jan 7, 2021
@yungezz
Copy link
Member

yungezz commented Jan 7, 2021

@fengzhou-msft Reverting the changes made in this PR: #16377 since the shortcode mapping list I was following was not consistent. I'll create another PR to update this with the new regions once we have a consistent naming convention.

hi @bragi92 could you pls have someone else to review this since this pure business logic? thanks

@yungezz yungezz added the AKS az aks/acs/openshift label Jan 7, 2021
@bragi92 bragi92 changed the title fix: revert to use old region mapping {AKS} revert to use old region mapping Jan 11, 2021
@bragi92
Copy link
Member Author

bragi92 commented Jan 11, 2021

@fengzhou-msft Can you have a look at this PR? Its reverting the change I made in #16377 since we're still talking with the other teams (I should have the new PR ready by end of this week)

Also do you know how I can run the build pipeline again ~ the PR title wasn't properly formatted but I've fixed it now.

@fengzhou-msft fengzhou-msft merged commit 4720ab9 into Azure:dev Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants