[Compute] Better error handling of external tokens #16406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Compute |
yungezz
reviewed
Jan 2, 2021
| else: | ||
| logger.warning('Getting external tokens failed.') | ||
| else: | ||
| logger.warning('Getting external tokens failed.') |
Member
There was a problem hiding this comment.
is this a warning or error? It will cause command failed at later right?
Member
Author
There was a problem hiding this comment.
Finally, it will fail in service side if service requires external tokens.
There was a problem hiding this comment.
This logger.warning() goes to the stderr and breaks our Azure DevOps pipeline, which now thinks that AzureCLI task printed some error. The command itself (az sig image-version create) works fine as it did before, returns JSON result with "provisioningState": "Succeeded".
|
This got me up and running again. |
yungezz
approved these changes
Jan 6, 2021
Co-authored-by: Feng Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #16391
External tokens in Track 2 SDk have problem. I am still investigating why it is None.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.