Skip to content

[Compute] Better error handling of external tokens #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 2 commits into from
Jan 8, 2021
Merged

[Compute] Better error handling of external tokens #16406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9effb0
[Compute] Better error handling of external tokens
qwordy Dec 31, 2020
f8cdf2f
Update src/azure-cli/azure/cli/command_modules/vm/custom.py
qwordy Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/azure-cli/azure/cli/command_modules/vm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3273,7 +3273,14 @@ def create_image_version(cmd, resource_group_name, gallery_name, gallery_image_n
cred, _, _ = profile.get_login_credentials(resource=resource,
aux_subscriptions=aux_subscriptions)
_, _, _, external_tokens = cred.get_all_tokens('https://management.azure.com/.default')
external_bearer_token = external_tokens[0][0] + ' ' + external_tokens[0][1]
if external_tokens:
external_token = external_tokens[0]
if len(external_token) >= 2:
external_bearer_token = external_token[0] + ' ' + external_token[1]
else:
logger.warning('Getting external tokens failed.')
else:
logger.warning('Getting external tokens failed.')
Copy link
Member

@yungezz yungezz Jan 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a warning or error? It will cause command failed at later right?

Copy link
Member Author

@qwordy qwordy Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, it will fail in service side if service requires external tokens.

Copy link

@eprigorodov eprigorodov Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logger.warning() goes to the stderr and breaks our Azure DevOps pipeline, which now thinks that AzureCLI task printed some error. The command itself (az sig image-version create) works fine as it did before, returns JSON result with "provisioningState": "Succeeded".


location = location or _get_resource_group_location(cmd.cli_ctx, resource_group_name)
end_of_life_date = fix_gallery_image_date_info(end_of_life_date)
Expand Down