[SQL] Upgrade azure-mgmt-sql to 0.26.0 #16618

Juliehzl · 2021-01-21T11:20:45Z

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

Sync

Merge from main repository

Merge from master repository

yonzhan · 2021-01-21T11:31:15Z

SQL

Juliehzl · 2021-01-21T12:36:45Z

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerMgmtScenarioTest::test_sql_server_public_network_access_update_mgmt @emgu-ms
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerDbMgmtScenarioTest::test_sql_db_mgmt @xaliciayang
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerDbMgmtScenarioTest::test_sql_db_read_replica_mgmt @bradrich-msft
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerDbLongTermRetentionScenarioTest::test_sql_db_long_term_retention @xaliciayang
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceOperationMgmtScenarioTest::test_sql_mi_operation_mgmt @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerDbRestoreDeletedScenarioTest::test_sql_db_restore_deleted
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerDwMgmtScenarioTest::test_sql_dw_mgmt @jaredmoo
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerImportExportMgmtScenarioTest::test_sql_db_import_export_mgmt @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceMgmtScenarioTest::test_sql_managed_instance_mgmt @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceMgmtScenarioIdentityTest::test_sql_managed_instance_create_identity_mgmt @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstancePoolScenarioTest::test_sql_instance_pool @rohands
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceDbShortTermRetentionScenarioTest::test_sql_managed_db_short_retention @xaliciayang
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceDbLongTermRetentionScenarioTest::test_sql_managed_db_long_term_retention @xaliciayang
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceRestoreDeletedDbScenarioTest::test_sql_managed_deleted_db_restore @djnisic @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceDbMgmtScenarioTest::test_sql_managed_db_mgmt @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlFailoverGroupMgmtScenarioTest::test_sql_failover_group_mgmt @maboja-msft @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlVirtualClusterMgmtScenarioTest::test_sql_virtual_cluster_mgmt @milostod @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlInstanceFailoverGroupMgmtScenarioTest::test_sql_instance_failover_group_mgmt @ziwa-msft @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlDbSensitivityClassificationsScenarioTest::test_sql_db_sensitivity_classifications @ranisha2
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedInstanceFailoverScenarionTest::test_sql_mi_failover_mgmt @MilanBrkicFON @petrajkogit
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlManagedDatabaseLogReplayScenarionTest::test_sql_midb_logreplay_mgmt @MilanBrkicFON

Juliehzl · 2021-01-22T02:18:11Z

Please comment in the PR with the following words and your PR link. For example,

Fix test_sql_server_public_network_access_create_mgmt: PR link

emgu-ms · 2021-01-22T02:59:58Z

Fix test_sql_server_public_network_access_create_mgmt: #16629

Juliehzl · 2021-01-22T03:40:21Z

Fix test_sql_server_public_network_access_create_mgmt: #16629

Pass

OlegSternbergIBM · 2021-01-22T08:06:56Z

Fixed recorded tests:
test_sql_db_import_export_mgmt.yaml
test_sql_failover_group_mgmt.yaml
test_sql_instance_pool.yaml
test_sql_managed_db_mgmt.yaml
test_sql_managed_db_short_retention.yaml
test_sql_managed_deleted_db_restore.yaml
test_sql_managed_instance_create_identity_mgmt.yaml
test_sql_managed_instance_mgmt.yaml
test_sql_mi_failover_mgmt.yaml
test_sql_midb_logreplay_mgmt.yaml
test_sql_virtual_cluster_mgmt.yaml
test_sql_db_sensitivity_classifications.yaml

PR link: #16631

OlegSternbergIBM · 2021-01-22T12:19:56Z

Fixed additional tests:
test_sql_db_mgmt.yaml
test_sql_db_read_replica_mgmt.yaml
test_sql_dw_mgmt.yaml

Was forced to change test_sql_commands.py - 'readReplicaCount' and 'readScale' fields had incorrect value.
Probably 'readReplicaCount' field is no longer in use.

PR link: #16631

petrajko · 2021-01-22T14:33:53Z

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py::SqlServerImportExportMgmtScenarioTest::test_sql_db_import_export_mgmt

@nathannfan is probably owning this one

OlegSternbergIBM · 2021-01-22T22:05:14Z

Fixed tests to use 'highAvailabilityReplicaCount' field per @bradrich-msft request

OlegSternbergIBM · 2021-01-23T16:08:49Z

Fixed additional recording YAML files
PR link: #16631

OlegSternbergIBM · 2021-01-25T20:23:25Z

Fixed test_sql_db_import_export_mgmt
PR link: #16631

* fix style error

OlegSternbergIBM · 2021-01-25T20:36:09Z

@Juliehzl please ensure you merge commit:
2d8a050

OlegSternbergIBM · 2021-01-26T07:57:09Z

Fixed test_sql_db_restore.yaml
PR link: #16631

evelyn-ys · 2021-01-27T06:37:10Z

src/azure-cli/azure/cli/command_modules/sql/_params.py

+    arg_ctx.argument('high_availability_replica_count',
                     arg_type=read_replicas_param_type)


Should Line537 be renamed too?

azure-cli/src/azure-cli/azure/cli/command_modules/sql/_params.py

Lines 537 to 539 in 6ab0ebf

arg_ctx.argument('read_replica_count',

options_list=['--read-replica-count'],

deprecate_info=arg_ctx.deprecate(hide=True))

evelyn-ys

Leave #16618 (comment) for later check (another PR to fix if necessary).
Approved to unblock test fixes🙂

emgu-ms and others added 9 commits February 27, 2020 18:30

Add PublicNetworkAccess to Create and Update Server

5d752a9

Merge branch 'dev' of https://github.com/Azure/azure-cli into dev

9c0c2c7

Merge branch 'dev' of https://github.com/Azure/azure-cli into dev

99f273f

Merge pull request #1 from Azure/dev

75a7998

Sync

Merge pull request #2 from Azure/dev

f530b90

Merge from main repository

Merge pull request Azure#4 from Azure/dev

e2e5cff

Merge from main repository

Merge pull request Azure#5 from Azure/dev

2c39056

Merge from master repository

Merge from upstream

71a2d1b

rerun test

a3235c1

Juliehzl requested review from evelyn-ys and jaredmoo as code owners January 21, 2021 11:20

yonzhan requested review from jsntcy and zhoxing-ms January 21, 2021 11:31

yonzhan assigned Juliehzl Jan 21, 2021

yonzhan added this to the S182 milestone Jan 21, 2021

emgu-ms added 2 commits January 21, 2021 18:34

Fix test_sql_server_public_network_access_update_mgmt test

dc08175

Remove left in testing

68682b7

Juliehzl added 2 commits January 22, 2021 11:13

revert failed test recordings

2988242

Merge branch 'emgu/FixPublicNetworkAccessTest' into sql

6c3565f

fix recorded tests

6c2d033

Juliehzl and others added 3 commits January 22, 2021 16:13

Merge branch 'fix_recorded_tests_sql_0_26_0' into sql

bfe06b8

fix additional tests

e2bd0bf

fix additional tests

9b48372

use highAvailabilityReplicaCount

7640716

fixed additional recorded tests

e9b1155

Juliehzl and others added 2 commits January 25, 2021 10:23

Merge branch 'fix_recorded_tests_sql_0_26_0' into sql

2df75f9

fixed test_sql_db_import_export_mgmt

b405f53

* move 'db_import' under correct group

2d8a050

* fix style error

Juliehzl and others added 3 commits January 26, 2021 11:38

Merge branch 'fix_recorded_tests_sql_0_26_0' into sql

96b2f4e

Fix read_replica_count

07f1b23

apply Oleg's change

e1eccf8

Oleg Sternberg and others added 2 commits January 26, 2021 16:40

fixed test_sql_db_restore.yaml

128fa3e

test_sql_db_mgmt fix

0b8e264

Juliehzl requested a review from bradrich-msft January 27, 2021 03:57

ericshape approved these changes Jan 27, 2021

View reviewed changes

evelyn-ys reviewed Jan 27, 2021

View reviewed changes

evelyn-ys approved these changes Jan 27, 2021

View reviewed changes

evelyn-ys merged commit 9928d45 into Azure:dev Jan 27, 2021

evelyn-ys mentioned this pull request Jan 28, 2021

[SQL] az test_sql_server_public_network_access_update_mgmt: Fix test #16629

Closed

3 tasks

		arg_ctx.argument('high_availability_replica_count',
		arg_type=read_replicas_param_type)

	arg_ctx.argument('read_replica_count',
	options_list=['--read-replica-count'],
	deprecate_info=arg_ctx.deprecate(hide=True))

[SQL] Upgrade azure-mgmt-sql to 0.26.0 #16618

[SQL] Upgrade azure-mgmt-sql to 0.26.0 #16618

Uh oh!

Conversation

Juliehzl commented Jan 21, 2021

Uh oh!

yonzhan commented Jan 21, 2021

Uh oh!

Juliehzl commented Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Juliehzl commented Jan 22, 2021

Uh oh!

emgu-ms commented Jan 22, 2021

Uh oh!

Juliehzl commented Jan 22, 2021

Uh oh!

OlegSternbergIBM commented Jan 22, 2021

Uh oh!

OlegSternbergIBM commented Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrajko commented Jan 22, 2021

Uh oh!

OlegSternbergIBM commented Jan 22, 2021

Uh oh!

OlegSternbergIBM commented Jan 23, 2021

Uh oh!

OlegSternbergIBM commented Jan 25, 2021

Uh oh!

OlegSternbergIBM commented Jan 25, 2021

Uh oh!

OlegSternbergIBM commented Jan 26, 2021

Uh oh!

evelyn-ys Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

evelyn-ys left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Juliehzl commented Jan 21, 2021 •

edited

Loading

OlegSternbergIBM commented Jan 22, 2021 •

edited

Loading