[SQL] Fix recorded SQL tests for SDK version 0.26.0 #16631
Conversation
Merge from main repository
Merge from main repository
Merge from master repository
OlegSternbergIBM
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
|
|
||
| information_type_id = response['informationTypeId'] | ||
| label_id = response['labelId'] |
There was a problem hiding this comment.
why not check them anymore?
There was a problem hiding this comment.
They do checked at lines: 5005 and 5006.
They just can't hold pre-generated values anymore since engine always generates them.
|
SQL |
|
Thank you for fixing test_sql_db_read_replica_mgmt. readReplicaCount has been replaced by highAvailabilityReplicaCount. If you don't mind, can you update that? |
| JMESPathCheck('status', 'Online'), | ||
| JMESPathCheck('zoneRedundant', False), | ||
| JMESPathCheck('readScale', 'Disabled'), | ||
| JMESPathCheck('readReplicaCount', '0'), |
There was a problem hiding this comment.
This is now 'highAvailabilityReplicaCount'
Done |
| JMESPathCheck('zoneRedundant', False), | ||
| JMESPathCheck('readScale', 'Disabled'), | ||
| JMESPathCheck('readReplicaCount', '0'), | ||
| JMESPathCheck('highAvailabilityReplicaCount', None), |
There was a problem hiding this comment.
Please keep previous check value.
|
Was created temporary to resolve test failures |
4 participants
Description
An engine change caused the below tests to break. This PR aims to fix that.
The fix adjusts recorded YAML files to unblock developers.
test_sql_db_import_export_mgmt.yaml
test_sql_failover_group_mgmt.yaml
test_sql_instance_pool.yaml
test_sql_managed_db_mgmt.yaml
test_sql_managed_db_short_retention.yaml
test_sql_managed_deleted_db_restore.yaml
test_sql_managed_instance_create_identity_mgmt.yaml
test_sql_managed_instance_mgmt.yaml
test_sql_mi_failover_mgmt.yaml
test_sql_midb_logreplay_mgmt.yaml
test_sql_virtual_cluster_mgmt.yaml
test_sql_db_sensitivity_classifications.yaml
There is also a fix in SqlDbSensitivityClassificationsScenarioTest class
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.