Skip to content

Conversation

@kristynhamasaki
Copy link
Contributor

@kristynhamasaki kristynhamasaki commented Feb 22, 2021

Description

Change needed for ignite with support of NetworkAclBypass.
-Adds params network_acl_bypass and network_acl_bypass_resource_ids to az cosmosdb update/create
-Adds update serverversion
-Adds params backup_retention and backup_inteval to az cosmosdb update/craete
Testing Guide

  • az cosmosdb create --name accountName --resource-group rgName --network-acl-bypass AzureServices --network-acl-bypass-resource-ids subscriptions/subId/resourceGroups/rgName/providers/Microsoft.Synapse/workspaces/wsName
  • az cosmosdb update --name accountName --resource-group rgName --network-acl-bypass AzureServices --network-acl-bypass-resource-ids subscriptions/subId/resourceGroups/rgName/providers/Microsoft.Synapse/workspaces/wsName
  • az cosmosdb update --name <account_name>--resource-group <resource_group> --server-version 4.0
    -az cosmosdb create --name accountName --resource-group rgName --backup-interval 240 --backup-retention 8
    -az cosmosdb update--name accountName --resource-group rgName --backup-interval 240 --backup-retention 8

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 22, 2021

CosmosDB

@yonzhan yonzhan added this to the S184 milestone Feb 22, 2021
@kristynhamasaki
Copy link
Contributor Author

Hi @yonzhan @Juliehzl This change is needed for Ignite, could we change the label to S183? Thank you!

@yonzhan yonzhan modified the milestones: S184, S183 - For Ignite Feb 22, 2021
@kristynhamasaki kristynhamasaki changed the title [CosmosDB] Upgrade to version 3.0.0 and add support for NetworkAclBypass [CosmosDB] Upgrade to version 3.0.0 and add support for NetworkAclBypass + Update Mongo ServerVersion Feb 22, 2021
@kavskalyan kavskalyan changed the title [CosmosDB] Upgrade to version 3.0.0 and add support for NetworkAclBypass + Update Mongo ServerVersion [CosmosDB] Upgrade to version 3.0.0 and add support for NetworkAclBypass + Update Mongo ServerVersion + backup policy Feb 22, 2021
@kristynhamasaki
Copy link
Contributor Author

Hi @Juliehzl We have combined this change with 2 other CosmosDB changes. Please review

@kavskalyan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kristynhamasaki
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 17021 in repo Azure/azure-cli

@kavskalyan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Juliehzl
Copy link
Contributor

Hi @kristynhamasaki , could you fix CI failures?

@kristynhamasaki
Copy link
Contributor Author

Hi @Juliehzl I reran the one test that hadn't been updated. Please queue the pipeline again. Thank you!

@Juliehzl Juliehzl closed this Feb 23, 2021
@Juliehzl Juliehzl reopened this Feb 23, 2021
@Juliehzl Juliehzl closed this Feb 23, 2021
@Juliehzl Juliehzl reopened this Feb 23, 2021
@Juliehzl
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Juliehzl
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kavskalyan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Juliehzl Juliehzl merged commit 1ba1fa6 into Azure:dev Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants