-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[CosmosDB] Upgrade to version 3.0.0 and add support for NetworkAclBypass + Update Mongo ServerVersion + backup policy #17021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CosmosDB |
Contributor
Author
Juliehzl
reviewed
Feb 22, 2021
Juliehzl
reviewed
Feb 22, 2021
…create and update commands
Contributor
Author
|
Hi @Juliehzl We have combined this change with 2 other CosmosDB changes. Please review |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17021 in repo Azure/azure-cli |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Juliehzl
approved these changes
Feb 23, 2021
Contributor
|
Hi @kristynhamasaki , could you fix CI failures? |
Contributor
Author
|
Hi @Juliehzl I reran the one test that hadn't been updated. Please queue the pipeline again. Thank you! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
msyyc
approved these changes
Feb 23, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change needed for ignite with support of NetworkAclBypass.
-Adds params network_acl_bypass and network_acl_bypass_resource_ids to az cosmosdb update/create
-Adds update serverversion
-Adds params backup_retention and backup_inteval to az cosmosdb update/craete
Testing Guide
-az cosmosdb create --name accountName --resource-group rgName --backup-interval 240 --backup-retention 8
-az cosmosdb update--name accountName --resource-group rgName --backup-interval 240 --backup-retention 8
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.