Skip to content

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Mar 16, 2021

Description

if only .yml files of test are changed, there is no need to ask real codeowners to approve before merge the PR

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@msyyc msyyc requested review from jsntcy and kairu-ms as code owners March 16, 2021 03:59
@msyyc msyyc self-assigned this Mar 16, 2021
@msyyc msyyc changed the title Update CODEOWNERS Update CODEOWNERS(Do not merge) Mar 16, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 16, 2021

CODEOWNERS

@yonzhan yonzhan added this to the S184 milestone Mar 16, 2021
@msyyc msyyc changed the title Update CODEOWNERS(Do not merge) {CI} Update CODEOWNERS(Do not merge) Mar 16, 2021
@msyyc
Copy link
Member Author

msyyc commented Mar 16, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@msyyc msyyc merged commit 1272df2 into dev Mar 16, 2021
Copy link
Member

@jiasli jiasli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost is a placeholder for deleted GitHub users. Why is this PR merge? Please kindly add some description.

@msyyc msyyc changed the title {CI} Update CODEOWNERS(Do not merge) {CI} Update CODEOWNERS Mar 16, 2021
@jiasli
Copy link
Member

jiasli commented Mar 16, 2021

If @ghost is a placeholder for non-owner files, please refer to the official document.

A non-official explanation I can find is https://github.amrom.workers.devmunity/t/codeowners-file-with-a-not-file-type-condition/1423/5

YAML files can contain credentials which should be manually reviewed (#16795).

msyyc added a commit that referenced this pull request Mar 16, 2021
@msyyc msyyc mentioned this pull request Mar 16, 2021
3 tasks
msyyc added a commit that referenced this pull request Mar 24, 2021
@jiasli jiasli deleted the yml-codeowner-change-2021-03-16 branch August 5, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants