-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Compute} Remove credentials from recordings #16795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@qwordy You could use azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py Line 4920 in da4239a
|
| class VMSSCrossTenantUpdateScenarioTest(LiveScenarioTest): | ||
|
|
||
| @ResourceGroupPreparer(name_prefix='cli_test_vmss_update_', location='westus2') | ||
| def test_vmss_cross_tenant_update(self, resource_group): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the test name to keep in sync with test_vm_cross_tenant_update:
- test_vmss_update_cross_tenant
+ test_vmss_cross_tenant_update
It was written by XXJ on 7/29/2020. |
|
I remember there is bug in |
Thank you so much! |
#14344, #14532 contains access tokens (credentials) in
x-ms-authorization-auxiliaryheaders.x-ms-authorization-auxiliarywill not be recorded anymore since Azure/azure-python-devtools@8915c3f, added by Azure/azure-python-devtools#46. This change is released inazure-devtools1.1.0.Azure CLI didn't take this change until #14477 which bumped
azure-devtoolsto 1.2.0 and was merged after #14344, #14532, so this issue is already fixed. Re-running the test won't recordx-ms-authorization-auxiliaryanymore.Actually, if a test is marked as
@live_only, no recording should be generated at all! This could be improved in the test framework.