[APIM] Fix APIM backup Service #17315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
APIM |
kairu-ms
reviewed
Mar 17, 2021
| c.argument('backup_name', help='The name of the backup file to create.') | ||
| c.argument('storage_account_name', arg_group='Storage', help='The name of the storage account used to place the backup.') | ||
| c.argument('storage_account_key', arg_group='Storage', help='The access key of the storage account used to place the backup.') | ||
| c.argument('storage_account_container', options_list=['--storage-account-container', '--container-name'], nargs='+', help='The name of the storage account container used to place the backup.') |
Contributor
There was a problem hiding this comment.
It's a breaking change on CLI command interface. Please provide more information to support this change.
Contributor
Author
There was a problem hiding this comment.
issue: #16262, this cli command already broken, need to fix it
kairu-ms
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #16262
Description
Testing Guide
History Notes
[APIM] BREAKING CHANGE:
apim backup:--storage-account-containernot support multi-value.[APIM] BREAKING CHANGE:
apim restore:--storage-account-containernot support multi-value.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.