Skip to content

Conversation

@hildurhodd
Copy link
Contributor

@hildurhodd hildurhodd commented Mar 19, 2021

Description

  • Update azure-mgmt-netapp dependency to version 2.0.0 and additions from that version added.
  • Migration of Python SDK from Track1 to Track2 changes.

Version 2.0.0 of Python SDK includes track 1 to track 2 migration along with additions from netapp API version 2020-12-01. User experience is not affected from the migration changes.

Migration changes are:

  • LRO operations are renamed to begin_xxx_xxx, for example in track1, the name is create_or_update; while in track2, the name is begin_create_or_update. This is only method name, not operation name.
  • In track2, SDK parameters are not flattened, so we need pass object parameter instead of flattened parameters to SDK. So more custom commands have been added instead of generic.
  • In track2, use ClientAuthenticationError, HttpResponseError, ResourceExistsError and ResourceNotFoundError instead of CloudError.
  • Fix some tests due to changes in track2.

Other changes:

  • Tests added and updated and new recordings made for all the tests.
  • Help was updated according to API changes.
  • Backup operations set to preview since it is only in private preview.
  • Backup tests marked to be skipped due to instability in CBS

Testing Guide

History Notes

[NetAppFiles] az netappfiles account ad add: Optional parameter added named allow-local-ldap-users
[NetAppFiles] az netappfiles volume create: Optional parameter added named ldap-enabled
[NetAppFiles] az netappfiles volume backup status show: Operation added


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan requested a review from kairu-ms March 19, 2021 17:27
@yonzhan yonzhan added this to the S185 milestone Mar 19, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 19, 2021

NetAppFiles

@jsntcy jsntcy requested a review from 00Kai0 March 23, 2021 03:07
@jsntcy jsntcy merged commit 490cafb into Azure:dev Mar 26, 2021
@hildurhodd hildurhodd deleted the Track2MigrationAndAPI2020-12-01 branch March 29, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants