Skip to content

[NetAppFiles] Update azure-mgmt-netapp version to 2.0.0 #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsntcy merged 12 commits into from
Mar 26, 2021
Merged

[NetAppFiles] Update azure-mgmt-netapp version to 2.0.0 #17370

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
75caf0b
added missing files
Mar 2, 2021
84d323e
Updated Python SDK to 2.0.0 which includes API version 2020-12-01
Mar 19, 2021
1c7f354
removing unwanted test
Mar 19, 2021
70a0776
Added help for volume backup status show
Mar 19, 2021
8c70e90
Added command-group help for volume backup status
Mar 19, 2021
3b612f0
pylint - disable line to long check for import statement
Mar 19, 2021
f6e3640
change default values from 0 to None
Mar 22, 2021
bd9e2fe
Remove volume backup status until it has been moved to backups_operat…
Mar 22, 2021
3239dc5
Fix after review: use base class HttpResponseError
Mar 23, 2021
f7565c5
rerun pipeline
Mar 23, 2021
23fe4b5
fix backup client factory
Mar 23, 2021
b953f98
Fix update backup
Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change default values from 0 to None
  • Loading branch information
hodd committed Mar 22, 2021
commit f6e36407dcbd5e2b22379f5ea3a9b9d3c9d83e49
24 changes: 12 additions & 12 deletions src/azure-cli/azure/cli/command_modules/netappfiles/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,10 @@ def create_snapshot(client, resource_group_name, account_name, pool_name, volume

# ---- SNAPSHOT POLICIES ----
def create_snapshot_policy(client, resource_group_name, account_name, snapshot_policy_name, location,
hourly_snapshots=0, hourly_minute=0,
daily_snapshots=0, daily_minute=0, daily_hour=0,
weekly_snapshots=0, weekly_minute=0, weekly_hour=0, weekly_day=None,
monthly_snapshots=0, monthly_minute=0, monthly_hour=0, monthly_days=None,
hourly_snapshots=None, hourly_minute=None,
daily_snapshots=None, daily_minute=None, daily_hour=None,
weekly_snapshots=None, weekly_minute=None, weekly_hour=None, weekly_day=None,
monthly_snapshots=None, monthly_minute=None, monthly_hour=None, monthly_days=None,
enabled=False, tags=None):
body = SnapshotPolicy(
location=location,
Expand All @@ -320,10 +320,10 @@ def create_snapshot_policy(client, resource_group_name, account_name, snapshot_p


def patch_snapshot_policy(client, resource_group_name, account_name, snapshot_policy_name, location,
hourly_snapshots=0, hourly_minute=0,
daily_snapshots=0, daily_minute=0, daily_hour=0,
weekly_snapshots=0, weekly_minute=0, weekly_hour=0, weekly_day=None,
monthly_snapshots=0, monthly_minute=0, monthly_hour=0, monthly_days=None,
hourly_snapshots=None, hourly_minute=None,
daily_snapshots=None, daily_minute=None, daily_hour=None,
weekly_snapshots=None, weekly_minute=None, weekly_hour=None, weekly_day=None,
monthly_snapshots=None, monthly_minute=None, monthly_hour=None, monthly_days=None,
enabled=False):
body = SnapshotPolicyPatch(
location=location,
Expand All @@ -350,8 +350,8 @@ def update_backup(client, resource_group_name, account_name, pool_name, volume_n

# ---- BACKUP POLICIES ----
def create_backup_policy(client, resource_group_name, account_name, backup_policy_name, location,
daily_backups=0, weekly_backups=0, monthly_backups=0,
yearly_backups=0, enabled=False, tags=None):
daily_backups=None, weekly_backups=None, monthly_backups=None,
yearly_backups=None, enabled=False, tags=None):
body = BackupPolicy(
location=location,
daily_backups_to_keep=daily_backups,
Expand All @@ -364,8 +364,8 @@ def create_backup_policy(client, resource_group_name, account_name, backup_polic


def patch_backup_policy(client, resource_group_name, account_name, backup_policy_name, location=None,
daily_backups=0, weekly_backups=0, monthly_backups=0,
yearly_backups=0, enabled=False, tags=None):
daily_backups=None, weekly_backups=None, monthly_backups=None,
yearly_backups=None, enabled=False, tags=None):
body = BackupPolicyPatch(
location=location,
daily_backups_to_keep=daily_backups,
Expand Down
Loading