Skip to content

Conversation

@jqhuangonearth
Copy link
Contributor

Description
Introduce async (--no-wait) options for search service and search shared-private-link-resource commands;

Testing Guide
N/A

History Notes
[Search] az search service create: Add async (--no-wait) options.
[Search] az search service update: Add async (--no-wait) options.
[Search] az search shared-private-link-resource create: Add async (--no-wait) options.
[Search] az search shared-private-link-resource update: Add async (--no-wait) options.

This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 25, 2021

Search

@yonzhan yonzhan added this to the S185 milestone Mar 25, 2021
@jqhuangonearth
Copy link
Contributor Author

@kairu-ms, any idea why the Azure.azure-cli check is always waiting for status to be reported? Is there an pipeline outage?

@yonzhan yonzhan requested a review from jiasli March 25, 2021 23:40
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

@kairu-ms, any idea why the Azure.azure-cli check is always waiting for status to be reported? Is there an pipeline outage?

Our pipeline needs manual trigger now, because it was attacked several weeks ago.

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add no_wait parameter in custom function signature and use sdk_no_wait to call LongRuningOperation. You can follow this example:

def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name,
linked_service_name, resource_id=None, write_access_resource_id=None,
no_wait=False):
from azure.mgmt.loganalytics.models import LinkedService
linked_service = LinkedService(resource_id=resource_id,
write_access_resource_id=write_access_resource_id)
return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name,
workspace_name, linked_service_name, linked_service)

@jqhuangonearth
Copy link
Contributor Author

You should add no_wait parameter in custom function signature and use sdk_no_wait to call LongRuningOperation. You can follow this example:

def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name,
linked_service_name, resource_id=None, write_access_resource_id=None,
no_wait=False):
from azure.mgmt.loganalytics.models import LinkedService
linked_service = LinkedService(resource_id=resource_id,
write_access_resource_id=write_access_resource_id)
return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name,
workspace_name, linked_service_name, linked_service)

This is done.

@jqhuangonearth
Copy link
Contributor Author

@kairu-ms
Copy link
Contributor

You miss help for some commands. Please see logs for details.

@jqhuangonearth
Copy link
Contributor Author

You miss help for some commands. Please see logs for details.

Gotcha. Will fix shortly.

@jqhuangonearth
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jqhuangonearth
Copy link
Contributor Author

@kairu-ms, all checks are passed and the change is ready to merge.

@kairu-ms kairu-ms merged commit 885be54 into Azure:dev Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants