-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Search] Introduce async options for service and shared-private-link-resource commands #17446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge Azure/azure-cli to my fork
Merge from base
…h as public ip rules, private endpoints, private link resources and msi; also add search provider in 'az network private-link-resource list'
…version; add corresponding tests
Merge from base
Pull from base
…-resource create'
|
Search |
|
@kairu-ms, any idea why the Azure.azure-cli check is always waiting for status to be reported? Is there an pipeline outage? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Our pipeline needs manual trigger now, because it was attacked several weeks ago. |
kairu-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add no_wait parameter in custom function signature and use sdk_no_wait to call LongRuningOperation. You can follow this example:
Lines 9 to 17 in ee405d3
| def create_log_analytics_workspace_linked_service(client, resource_group_name, workspace_name, | |
| linked_service_name, resource_id=None, write_access_resource_id=None, | |
| no_wait=False): | |
| from azure.mgmt.loganalytics.models import LinkedService | |
| linked_service = LinkedService(resource_id=resource_id, | |
| write_access_resource_id=write_access_resource_id) | |
| return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, | |
| workspace_name, linked_service_name, linked_service) |
This is done. |
|
@kairu-ms, why is it failed when the LINT is [PASSED]: https://dev.azure.com/azure-sdk/public/_build/results?buildId=813902&view=logs&j=168ccbe3-da49-5c0b-6478-08f7016e4bf5&t=10a595be-4223-5cc7-9a73-012871b6eaee |
|
You miss help for some commands. Please see logs for details. |
Gotcha. Will fix shortly. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@kairu-ms, all checks are passed and the change is ready to merge. |
Description
Introduce async (--no-wait) options for
search serviceandsearch shared-private-link-resourcecommands;Testing Guide
N/A
History Notes
[Search] az search service create: Add async (--no-wait) options.
[Search] az search service update: Add async (--no-wait) options.
[Search] az search shared-private-link-resource create: Add async (--no-wait) options.
[Search] az search shared-private-link-resource update: Add async (--no-wait) options.
This checklist is used to make sure that common guidelines for a pull request are followed.
[x ] The PR title and description has followed the guideline in Submitting Pull Requests.
[ x] I adhere to the Command Guidelines.
[ x] I adhere to the Error Handling Guidelines.