Skip to content

[Search] Introduce async options for service and shared-private-link-resource commands #17446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 21 commits into from
Apr 1, 2021
Merged

[Search] Introduce async options for service and shared-private-link-resource commands #17446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
38d450c
Merge pull request #1 from Azure/dev
Jan 19, 2021
a4a0603
Merge pull request #2 from Azure/dev
Jan 27, 2021
045ea3d
upgrade az search to use the latest sdk version with new features suc…
Jan 27, 2021
a52dc25
fix update endpoint to use the begin_create_or_update in the new sdk …
Jan 28, 2021
359126e
fix the azure-cli requirements
Jan 28, 2021
9f2b929
fix the test failure; fix style and liner
Jan 28, 2021
d64f013
fix the public-network-access param; fix cli liner
Jan 28, 2021
8030b2e
add actions-required param when updating pe connection
Jan 28, 2021
6ec5e96
address comments to follow best-practise naming conventions
Jan 30, 2021
59c16dd
fix CLI style
Jan 30, 2021
d74dc7f
disable pylint too-manage-arguments
Jan 30, 2021
6013515
fix build failure
Jan 30, 2021
ad40dec
resolve merge conflicts
Feb 9, 2021
c660ed7
Merge pull request #5 from Azure/dev
Feb 22, 2021
df08063
fix the help manual for identity_type
Feb 22, 2021
feb84a4
Merge pull request #6 from Azure/dev
Mar 24, 2021
ac87ef2
support --no-wait for 'search create' and 'search shared-private-link…
Mar 25, 2021
2e65f07
Merge pull request #7 from Azure/dev
Mar 30, 2021
d057f82
use sdk_no_wait util to invoke async operations
Mar 30, 2021
f6b0aaf
remove unused parameters in update_search_service
Mar 30, 2021
32ebd7b
add missing help
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the public-network-access param; fix cli liner
  • Loading branch information
Bolun Huang committed Jan 28, 2021
commit d64f013785bfd9f6232bcc2fac4d9e88e61c347a
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/search/_client_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ def cf_search_admin_keys(cli_ctx, _):


def cf_search_query_keys(cli_ctx, _):
return cf_search(cli_ctx).query_keys
return cf_search(cli_ctx).query_keys
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/search/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ def load_arguments(self, _):
with self.argument_context('search service create') as c:
c.ignore('search_management_request_options')
c.argument('sku', help='Search Service SKU', arg_type=get_enum_type(["Free", "Basic", "Standard", "Standard2", "Standard3"]))
c.argument('public_network_access', options_list=['--public_network_access', '--public-access'])
c.argument('public_network_access', options_list=['--public-network-access', '--public-access'])

with self.argument_context('search service update') as c:
c.ignore('search_management_request_options')
c.argument('public_network_access', options_list=['--public_network_access', '--public-access'])
c.argument('public_network_access', options_list=['--public-network-access', '--public-access'])

with self.argument_context('search privateendpointconnection') as c:
c.ignore('search_management_request_options')
Expand Down
Loading