Skip to content

[RDBMS] Allowing DB server private access from different subscription #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 5 commits into from
Mar 30, 2021
Merged

[RDBMS] Allowing DB server private access from different subscription #17502

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
170ab72
make tests fail when server provisioning fail
DaeunYim Mar 23, 2021
97815ae
params bug fix
DaeunYim Mar 25, 2021
8c9d0be
db CURD bug fix
DaeunYim Mar 29, 2021
0587ccb
vnet from different subscription enabled server
DaeunYim Mar 30, 2021
04b3793
fix CI test failure
DaeunYim Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
params bug fix
  • Loading branch information
@DaeunYim
DaeunYim committed Mar 25, 2021
commit 97815aed8f40a5e3ab4fa495de386903e7b5c62f
6 changes: 3 additions & 3 deletions src/azure-cli/azure/cli/command_modules/rdbms/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def _flexible_server_params(command_group):
validator=retention_validator)
c.argument('version', default='12', options_list=['--version'],
help='Server major version.')
c.argument('zone', options_list=['--zone, -z'],
c.argument('zone', options_list=['--zone', '-z'],
help='Availability zone into which to provision the resource.')
elif command_group == 'mysql':
c.argument('tier', default='Burstable',
Expand All @@ -275,7 +275,7 @@ def _flexible_server_params(command_group):
help='The number of days a backup is retained. Range of 7 to 35 days. Default is 7 days.')
c.argument('version', default='5.7', options_list=['--version'],
help='Server major version.')
c.argument('zone', options_list=['--zone, -z'],
c.argument('zone', options_list=['--zone', '-z'],
help='Availability zone into which to provision the resource.')
c.argument('iops', type=int, options_list=['--iops'],
help='Number of IOPS to be allocated for this server. You will get certain amount of free IOPS based '
Expand All @@ -289,7 +289,7 @@ def _flexible_server_params(command_group):
help='Resource ID of an existing subnet. Please note that the subnet will be delegated to Microsoft.DBforPostgreSQL/flexibleServers/Microsoft.DBforMySQL/flexibleServers.After delegation, this subnet cannot be used for any other type of Azure resources.')
c.argument('server_name', options_list=['--name', '-n'], arg_type=server_name_setter_arg_type)
c.argument('location', arg_type=get_location_type(self.cli_ctx))
c.argument('administrator_login', default=generate_username(), options_list=['--admin-user, -u'], arg_group='Authentication', arg_type=administrator_login_setter_arg_type,
c.argument('administrator_login', default=generate_username(), options_list=['--admin-user', '-u'], arg_group='Authentication', arg_type=administrator_login_setter_arg_type,
help='Administrator username for the server. Once set, it cannot be changed. ')
c.argument('administrator_login_password', options_list=['--admin-password', '-p'],
help='The password of the administrator. Minimum 8 characters and maximum 128 characters. Password must contain characters from three of the following categories: English uppercase letters, English lowercase letters, numbers, and non-alphanumeric characters.',
Expand Down