-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[IoT Hub] Track 2 updates and managed identity implementation #18098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c75e60e
IoT Hub track 2 updates and managed identity implementation (#2)
c-ryan-k ef05589
Test recording updates with 2.0.0 SDK
c-ryan-k d6005a9
Fixes for hyrid profile commands / tests and iot_security tests
c-ryan-k 5c394ee
String fixes from code review
c-ryan-k 6164e87
Updated CLIErrors for missing params to use RequiredArgumentMissingError
c-ryan-k b4affcf
Merge branch 'azure-dev' into dev
c-ryan-k a38a985
Fix CLIError -> ArgumentUsageError
c-ryan-k 44e6e20
Merge branch 'dev' of https://github.com/c-ryan-k/azure-cli into dev
c-ryan-k e9633f4
PR feedback and test updates
c-ryan-k d60a1a7
New format for managed identity parameters
c-ryan-k 6fc1bfc
Fix wrong parameter in error description
c-ryan-k f8ec73d
Removed identity update command
c-ryan-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[system]is a string used to refer to the system-assigned managed identity, we wanted to keep in line with other services using the same parameter - just a few other examples:azure-cli/src/azure-cli/azure/cli/command_modules/appconfig/custom.py
Line 28 in f30478c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c-ryan-k Hi, our team has a meeting today to discuss how to redesign the parameters of managed identity, the parameters related to managed identity need to be modified to a new interface:
We recommend using
--mi-system-assignedto enable system-assigned identity and--mi-user-assignedwith space separated resource IDs to add user-assigned identities instead of a mixed parameter.For more details, please refer to this guideline doc link, could you please take a look~