Skip to content

Conversation

@bennerv
Copy link
Member

@bennerv bennerv commented Oct 28, 2021

Description
As part of an AAD breaking change, an aad application no longer supports identifier_uris with custom domains that aren't verified in a customer's tenant.

This removes the identifier_uris ARO creates during the az aro create process as they are not needed and prevent cluster creation in customer's subscriptions.

Testing Guide
Ran the live tests. Created a local cluster using az aro create


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 28, 2021
@ghost
Copy link

ghost commented Oct 28, 2021

Thank you for your contribution bennerv! We will review the pull request and get back to you soon.

@bennerv bennerv changed the title Aro remove identifier uris [ARO] Remove Identifier URLs Oct 28, 2021
@bennerv bennerv changed the title [ARO] Remove Identifier URLs [ARO] Remove Identifier URIs Oct 28, 2021
@bennerv bennerv force-pushed the aro-remove-identifier-uris branch 2 times, most recently from c7cb557 to f9afb13 Compare October 28, 2021 22:31
@bennerv bennerv force-pushed the aro-remove-identifier-uris branch from f9afb13 to e700aa8 Compare October 28, 2021 22:42
@yonzhan yonzhan requested a review from jiasli October 28, 2021 22:56
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2021

ARO

@rogbas
Copy link

rogbas commented Oct 28, 2021

LGTM

@evelyn-ys evelyn-ys changed the title [ARO] Remove Identifier URIs [ARO] az aro create: Remove Identifier URIs Oct 29, 2021
@jiasli
Copy link
Member

jiasli commented Nov 5, 2021

FYI, az ad sp create-for-rbac fixed this issue in #18312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants