Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
/src/azure-cli/azure/cli/command_modules/apim/ @kevinhillinger @jonlester
/src/azure-cli/azure/cli/command_modules/appconfig/ @shenmuxiaosen @avanigupta @zhoxing-ms @jsntcy
/src/azure-cli/azure/cli/command_modules/appservice/ @panchagnula @jsntcy @zhoxing-ms
/src/azure-cli/azure/cli/command_modules/aro/ @mjudeikis @jim-minter
/src/azure-cli/azure/cli/command_modules/aro/ @bennerv @hawkowl @jewzaam @m1kola @mwoodson @rogbas
/src/azure-cli/azure/cli/command_modules/backup/ @dragonfly91 @zhoxing-ms @akshayneema @jsntcy
/src/azure-cli/azure/cli/command_modules/batch/ @bgklein @gingi @dpwatrous @paterasMSFT @zhoxing-ms @jsntcy
/src/azure-cli/azure/cli/command_modules/batchai/ @AlexanderYukhanov
Expand Down
8 changes: 2 additions & 6 deletions src/azure-cli/azure/cli/command_modules/aro/_aad.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@


class AADManager:
MANAGED_APP_PREFIX = 'https://az.aro.azure.com/'

def __init__(self, cli_ctx):
profile = Profile(cli_ctx=cli_ctx)
credentials, _, tenant_id = profile.get_login_credentials(
Expand All @@ -38,9 +36,7 @@ def create_application(self, display_name):

app = self.client.applications.create(ApplicationCreateParameters(
display_name=display_name,
identifier_uris=[
self.MANAGED_APP_PREFIX + str(uuid.uuid4()),
],
identifier_uris=[],
password_credentials=[
PasswordCredential(
custom_key_identifier=str(start_date).encode(),
Expand Down Expand Up @@ -97,7 +93,7 @@ def refresh_application_credentials(self, object_id):
# https://github.com/Azure/azure-sdk-for-python/issues/18131
for c in credentials:
if c.custom_key_identifier is None:
raise BadRequestError("Cluster AAD application contains a client secret with an empty description.\n\
raise BadRequestError("Cluster AAD application contains a client secret with an empty identifier.\n\
Please either manually remove the existing client secret and run `az aro update --refresh-credentials`, \n\
or manually create a new client secret and run `az aro update --client-secret <ClientSecret>`.")

Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.