Skip to content

Conversation

@houk-ms
Copy link
Contributor

@houk-ms houk-ms commented Mar 23, 2022

Description

This PR

  1. Adds supports for more target resources: redis and redis-enterprise.
  2. Adds support for AKS as source resource. It is hidden from customers in this PR, and will be shown to users after service connector's new api version is ready.
  3. Provide --deployment the default value default for az spring-cloud connection.
  4. Fix some known issues in arguement and command help message.

Testing Guide

History Notes

[ServiceConnector] az webapp/spring-cloud connection: Add command create redis/redis-enterprise to support more target resources


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added Redis Cache Auto-Assign Auto assign by bot labels Mar 23, 2022
@ghost ghost requested review from evelyn-ys, jsntcy and yonzhan March 23, 2022 04:01
@ghost ghost assigned evelyn-ys Mar 23, 2022
@ghost ghost added this to the Mar 2022 (2022-04-06) milestone Mar 23, 2022
@ghost ghost requested review from kairu-ms and zhoxing-ms March 23, 2022 04:01
@ghost ghost assigned zhoxing-ms Mar 23, 2022
@ghost ghost added the Web Apps az webapp label Mar 23, 2022
@ghost ghost requested a review from wangzelin007 March 23, 2022 04:01
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 23, 2022

ServiceConnector

@yonzhan yonzhan removed Web Apps az webapp Redis Cache Auto-Assign Auto assign by bot labels Mar 23, 2022
@houk-ms houk-ms requested review from xfz11 and yungezz March 23, 2022 08:26
@kairu-ms
Copy link
Contributor

@houk-ms, Could you fill [History Notes] of your PR?

@houk-ms houk-ms changed the title [ServiceConnector] az webapp/spring-cloud connection create redis/redis-enterprise: Add support for more target resources [ServiceConnector] az webapp/spring-cloud connection: Add command create redis/redis-enterprise to support more target resources Mar 28, 2022
@houk-ms
Copy link
Contributor Author

houk-ms commented Mar 28, 2022

@kairu-ms added.

@houk-ms
Copy link
Contributor Author

houk-ms commented Mar 28, 2022

@kairu-ms Can you help merge the pr when you think it's ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants