Skip to content

[ServiceConnector] az webapp/spring-cloud connection: Add command create redis/redis-enterprise to support more target resources #21763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 2 commits into from
Mar 28, 2022
Merged

[ServiceConnector] az webapp/spring-cloud connection: Add command create redis/redis-enterprise to support more target resources #21763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4575d70
support more targets and source resources
houk-ms Mar 23, 2022
41fe464
deployment argument defaults to [default] for spring-cloud connection
houk-ms Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/serviceconnector/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def get_auth_info_params(auth_type):
# special target resource, independent implementation
target = RESOURCE.ConfluentKafka
server_params = ('--bootstrap-server xxx.eastus.azure.confluent.cloud:9092 '
'--kafka-key Name --kafka-secret Secret ')
'--kafka-key Name --kafka-secret Secret')
registry_params = ('--schema-registry https://xxx.eastus.azure.confluent.cloud '
'--schema-key Name --schema-secret Secret')

Expand Down
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/serviceconnector/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ def add_source_resource_block(context, source, enable_id=True, validate_source_i

required_args = []
for arg, content in SOURCE_RESOURCES_PARAMS.get(source).items():
id_arg = '\'--id\'' if enable_id else '\'--source-id\''
context.argument(arg, options_list=content.get('options'), type=str,
help='{}. Required if \'--source-id\' is not specified.'.format(content.get('help')))
help='{}. Required if {} is not specified.'.format(content.get('help'), id_arg))
required_args.append(content.get('options')[0])

validator_kwargs = {'validator': validate_params} if validate_source_id else {}
Expand Down
Loading