{Compute} Change KeyVaultClient to CertificateClient in vm module
#26991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReaNAiveD
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @ReaNAiveD, |
ghost
requested a review
from
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
zhoxing-ms
approved these changes
Jul 31, 2023
evelyn-ys
approved these changes
Aug 1, 2023
Member
|
It will be great if the PR description can explain why |
Member
Author
Updated |
Member
|
The new PR description looks perfect! 🎉 |
jiasli
reviewed
Aug 7, 2023
Comment on lines
+108
to
+110
| def create_keyvault_data_plane_client(cli_ctx, vault_base_url): | ||
| from azure.cli.command_modules.keyvault._client_factory import data_plane_azure_keyvault_certificate_client | ||
| return data_plane_azure_keyvault_certificate_client(cli_ctx, {"vault_base_url": vault_base_url}) |
Member
There was a problem hiding this comment.
This create_keyvault_data_plane_client function internally calls azure.cli.command_modules.keyvault._client_factory.data_plane_azure_keyvault_certificate_client which returns a azure.keyvault.certificates.CertificateClient, making the name of this function no longer valid.
Member
Author
There was a problem hiding this comment.
This
create_keyvault_data_plane_clientfunctions returns aazure.keyvault.certificates.CertificateClient, making the name of this function no longer valid.
I see. I will create a new PR to implement this change.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
vm secret addvm encryption enablevmss encryption enableDescription
Change
azure.keyvault.KeyVaultClienttoazure.keyvault.certificates.CertificateClientin vm module.Package
azure-keyvaultis incompatible with Python 3.11, becauseinspect.getargspecis removed in Python 3.11.Ref: microsoft/knack#275 (comment)
Testing Guide
vm secret add -g myGroup -n vm --keyvault vault --certificate certvm encryption enable -g myGroup -n vm --disk-encryption-keyvault vaultvmss encryption enable -g myGroup -n vmss --disk-encryption-keyvault vaultHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.