[Compute] Fix #27446: az vm encryption enable: Fix using incorrect client when --key-encryption-key is specified
#27493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReaNAiveD
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Compute fix |
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm encryption enableDescription
Fix #27446
The command accepts
--key-encryption-keyto encrypt the disk encryption key.However, when converting the key name to a URL, a
CertificateClientis used instead of aKeyClient. which causing an error because the CertificateClient object is meant for managing certificates, not keys.The bug was introduced in #26991 , which updated
azure-keyvaultpackage toazure-keyvault-key/azure-keyvault-secret/azure-keyvault-certificate.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.